-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) Restore offline patient banner #818
(fix) Restore offline patient banner #818
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two things:
- I think it's better to keep to the convention we've established of
offlineBannerComponent
- It's preferable to have the exports in roughly the same order they are in the routes.json. In other words, the offlineBanner export should come after the localeChanger and before the linkComponent
Thanks for the review @ibacher ! I've addressed the feedback and pushed the changes. |
@@ -22,7 +22,7 @@ import { isDesktop } from "../../utils"; | |||
import AppMenuPanel from "../navbar-header-panels/app-menu-panel.component"; | |||
import Logo from "../logo/logo.component"; | |||
import NotificationsMenuPanel from "../navbar-header-panels/notifications-menu-panel.component"; | |||
import OfflineBanner from "../offline-banner/offline-banner.component"; | |||
import OfflineBannerComponent from "../offline-banner/offline-banner.component"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are unnecessary! We just needed things in index.ts
to be consistent. We don't need to rename it everywhere!
Requirements
For changes to apps
If applicable
Summary
This pull request aims to restore the offline banner feature, ensuring that an appropriate banner is displayed when the application is offline. The implementation involves reintegrating the offline banner component and associated logic to enhance user experience during periods of network unavailability.
Screenshots
Before:
After:
Related Issue
Other
Thanks,
CC: @ibacher