(fix) Fix Webpack compilation error logging on build #829
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
For changes to apps
If applicable
Summary
When encountering a webpack compilation error during the build process, it logs
[openmrs] undefined
. This issue becomes evident in recent build failures[1][2]. The root cause lies in the logger expecting an Error object during promise rejection, but the provided object is not of type Error, leading to a failure in logging the corresponding message.To address this, I've modified the handling of errors. The
stats?.compilation.errors
array contains webpack error objects. To facilitate proper logging, I have converted this array into a string and thrown it as a new Error object.[1] https://github.com/openmrs/openmrs-distro-referenceapplication/actions/runs/7069093486/job/19244414755?pr=765
[2] https://ci.openmrs.org/browse/REFAPP-D3X-F2-2054/log
Screenshots
Related Issue
Other