Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) Pin Carbon versions #831

Merged
merged 1 commit into from
Dec 4, 2023
Merged

(fix) Pin Carbon versions #831

merged 1 commit into from
Dec 4, 2023

Conversation

denniskigen
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

Frontend builds are currently broken because of how npx resolves transitive dependencies. The version of @carbon/icons getting resolved is broken upstream. The fix is to pin the @carbon/react dependency to a known working version instead of the latest version.

Screenshots

Broken frontend build

image

Related Issue

None

Other

None

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023

Size Change: 0 B

Total Size: 2.61 MB

ℹ️ View Unchanged
Filename Size
packages/apps/esm-devtools-app/dist/68.js 4.66 kB
packages/apps/esm-devtools-app/dist/735.js 2.63 kB
packages/apps/esm-devtools-app/dist/889.js 107 kB
packages/apps/esm-devtools-app/dist/988.js 282 B
packages/apps/esm-devtools-app/dist/main.js 2.95 kB
packages/apps/esm-devtools-app/dist/openmrs-esm-devtools-app.js 3.03 kB
packages/apps/esm-implementer-tools-app/dist/263.js 6.66 kB
packages/apps/esm-implementer-tools-app/dist/285.js 60.8 kB
packages/apps/esm-implementer-tools-app/dist/319.js 633 B
packages/apps/esm-implementer-tools-app/dist/329.js 10 kB
packages/apps/esm-implementer-tools-app/dist/426.js 1.66 kB
packages/apps/esm-implementer-tools-app/dist/460.js 735 B
packages/apps/esm-implementer-tools-app/dist/56.js 3.07 kB
packages/apps/esm-implementer-tools-app/dist/560.js 9.6 kB
packages/apps/esm-implementer-tools-app/dist/574.js 560 B
packages/apps/esm-implementer-tools-app/dist/587.js 2.81 kB
packages/apps/esm-implementer-tools-app/dist/620.js 126 kB
packages/apps/esm-implementer-tools-app/dist/625.js 562 B
packages/apps/esm-implementer-tools-app/dist/727.js 32.9 kB
packages/apps/esm-implementer-tools-app/dist/735.js 2.63 kB
packages/apps/esm-implementer-tools-app/dist/757.js 560 B
packages/apps/esm-implementer-tools-app/dist/788.js 42.9 kB
packages/apps/esm-implementer-tools-app/dist/807.js 559 B
packages/apps/esm-implementer-tools-app/dist/833.js 681 B
packages/apps/esm-implementer-tools-app/dist/889.js 107 kB
packages/apps/esm-implementer-tools-app/dist/main.js 72.8 kB
packages/apps/esm-implementer-tools-app/dist/openmrs-esm-implementer-tools-app.js 3.31 kB
packages/apps/esm-login-app/dist/111.js 1.22 kB
packages/apps/esm-login-app/dist/126.js 2.5 kB
packages/apps/esm-login-app/dist/173.js 1.22 kB
packages/apps/esm-login-app/dist/224.js 256 B
packages/apps/esm-login-app/dist/236.js 272 B
packages/apps/esm-login-app/dist/240.js 364 B
packages/apps/esm-login-app/dist/263.js 6.65 kB
packages/apps/esm-login-app/dist/272.js 264 B
packages/apps/esm-login-app/dist/319.js 692 B
packages/apps/esm-login-app/dist/336.js 234 B
packages/apps/esm-login-app/dist/370.js 27.2 kB
packages/apps/esm-login-app/dist/460.js 782 B
packages/apps/esm-login-app/dist/539.js 298 B
packages/apps/esm-login-app/dist/56.js 3.06 kB
packages/apps/esm-login-app/dist/574.js 609 B
packages/apps/esm-login-app/dist/625.js 600 B
packages/apps/esm-login-app/dist/627.js 257 B
packages/apps/esm-login-app/dist/63.js 16.5 kB
packages/apps/esm-login-app/dist/644.js 305 B
packages/apps/esm-login-app/dist/673.js 284 B
packages/apps/esm-login-app/dist/735.js 2.63 kB
packages/apps/esm-login-app/dist/757.js 698 B
packages/apps/esm-login-app/dist/788.js 42.9 kB
packages/apps/esm-login-app/dist/807.js 961 B
packages/apps/esm-login-app/dist/812.js 22.5 kB
packages/apps/esm-login-app/dist/833.js 727 B
packages/apps/esm-login-app/dist/889.js 107 kB
packages/apps/esm-login-app/dist/main.js 53.6 kB
packages/apps/esm-login-app/dist/openmrs-esm-login-app.js 3.32 kB
packages/apps/esm-offline-tools-app/dist/102.js 81.3 kB
packages/apps/esm-offline-tools-app/dist/193.js 55.1 kB
packages/apps/esm-offline-tools-app/dist/263.js 6.66 kB
packages/apps/esm-offline-tools-app/dist/319.js 1.14 kB
packages/apps/esm-offline-tools-app/dist/460.js 1.32 kB
packages/apps/esm-offline-tools-app/dist/56.js 3.07 kB
packages/apps/esm-offline-tools-app/dist/574.js 1.04 kB
packages/apps/esm-offline-tools-app/dist/625.js 1.04 kB
packages/apps/esm-offline-tools-app/dist/63.js 16.5 kB
packages/apps/esm-offline-tools-app/dist/735.js 2.63 kB
packages/apps/esm-offline-tools-app/dist/757.js 1.2 kB
packages/apps/esm-offline-tools-app/dist/788.js 42.9 kB
packages/apps/esm-offline-tools-app/dist/807.js 1.1 kB
packages/apps/esm-offline-tools-app/dist/833.js 1.22 kB
packages/apps/esm-offline-tools-app/dist/889.js 107 kB
packages/apps/esm-offline-tools-app/dist/main.js 136 kB
packages/apps/esm-offline-tools-app/dist/openmrs-esm-offline-tools-app.js 3.29 kB
packages/apps/esm-primary-navigation-app/dist/262.js 13.3 kB
packages/apps/esm-primary-navigation-app/dist/263.js 6.66 kB
packages/apps/esm-primary-navigation-app/dist/319.js 200 B
packages/apps/esm-primary-navigation-app/dist/460.js 217 B
packages/apps/esm-primary-navigation-app/dist/574.js 183 B
packages/apps/esm-primary-navigation-app/dist/625.js 184 B
packages/apps/esm-primary-navigation-app/dist/63.js 16.5 kB
packages/apps/esm-primary-navigation-app/dist/735.js 18.7 kB
packages/apps/esm-primary-navigation-app/dist/757.js 209 B
packages/apps/esm-primary-navigation-app/dist/788.js 42.9 kB
packages/apps/esm-primary-navigation-app/dist/807.js 235 B
packages/apps/esm-primary-navigation-app/dist/833.js 210 B
packages/apps/esm-primary-navigation-app/dist/889.js 107 kB
packages/apps/esm-primary-navigation-app/dist/960.js 2.64 kB
packages/apps/esm-primary-navigation-app/dist/main.js 33.7 kB
packages/apps/esm-primary-navigation-app/dist/openmrs-esm-primary-navigation-app.js 3.23 kB
packages/framework/esm-api/dist/openmrs-esm-api.js 9.75 kB
packages/framework/esm-breadcrumbs/dist/openmrs-esm-breadcrumbs.js 2.66 kB
packages/framework/esm-config/dist/openmrs-esm-module-config.js 7.87 kB
packages/framework/esm-dynamic-loading/dist/openmrs-esm-dynamic-loading.js 2.12 kB
packages/framework/esm-error-handling/dist/openmrs-esm-error-handling.js 894 B
packages/framework/esm-extensions/dist/openmrs-esm-extensions.js 8.05 kB
packages/framework/esm-feature-flags/dist/openmrs-esm-feature-flags.js 1.67 kB
packages/framework/esm-framework/dist/146.openmrs-esm-framework.js 6.69 kB
packages/framework/esm-framework/dist/455.openmrs-esm-framework.js 4.57 kB
packages/framework/esm-framework/dist/530.openmrs-esm-framework.js 2.92 kB
packages/framework/esm-framework/dist/645.openmrs-esm-framework.js 9.31 kB
packages/framework/esm-framework/dist/710.openmrs-esm-framework.js 6.48 kB
packages/framework/esm-framework/dist/735.openmrs-esm-framework.js 2.66 kB
packages/framework/esm-framework/dist/788.openmrs-esm-framework.js 42.9 kB
packages/framework/esm-framework/dist/openmrs-esm-framework.js 374 kB
packages/framework/esm-globals/dist/openmrs-esm-globals.js 756 B
packages/framework/esm-offline/dist/openmrs-esm-offline.js 34.4 kB
packages/framework/esm-react-utils/dist/openmrs-esm-react-utils.js 15.2 kB
packages/framework/esm-state/dist/openmrs-esm-state.js 888 B
packages/framework/esm-styleguide/dist/openmrs-esm-styleguide.js 19.3 kB
packages/framework/esm-utils/dist/openmrs-esm-utils.js 11 kB
packages/shell/esm-app-shell/dist/25018673bc6f380f.js 6.03 kB
packages/shell/esm-app-shell/dist/498a8af91d44612e.js 4.1 kB
packages/shell/esm-app-shell/dist/966c4dfec919951f.js 1.58 kB
packages/shell/esm-app-shell/dist/openmrs.ec61c2246005ff04.js 332 kB
packages/shell/esm-app-shell/dist/service-worker.js 60.4 kB
packages/tooling/openmrs/dist/cli.js 3.09 kB
packages/tooling/openmrs/dist/commands/assemble.js 2.73 kB
packages/tooling/openmrs/dist/commands/build.js 1.66 kB
packages/tooling/openmrs/dist/commands/debug.js 579 B
packages/tooling/openmrs/dist/commands/develop.js 1.86 kB
packages/tooling/openmrs/dist/commands/index.js 438 B
packages/tooling/openmrs/dist/commands/start.js 848 B
packages/tooling/openmrs/dist/index.js 517 B
packages/tooling/openmrs/dist/runner.js 870 B
packages/tooling/openmrs/dist/utils/config.js 726 B
packages/tooling/openmrs/dist/utils/debugger.js 529 B
packages/tooling/openmrs/dist/utils/dependencies.js 639 B
packages/tooling/openmrs/dist/utils/helpers.js 393 B
packages/tooling/openmrs/dist/utils/importmap.js 3.25 kB
packages/tooling/openmrs/dist/utils/index.js 444 B
packages/tooling/openmrs/dist/utils/logger.js 234 B
packages/tooling/openmrs/dist/utils/npmConfig.js 854 B
packages/tooling/openmrs/dist/utils/untar.js 721 B
packages/tooling/openmrs/dist/utils/variables.js 192 B
packages/tooling/openmrs/dist/utils/webpack.js 276 B
packages/tooling/webpack-config/dist/index.js 3.58 kB

compressed-size-action

@vasharma05 vasharma05 merged commit dd97b8d into main Dec 4, 2023
9 checks passed
@vasharma05 vasharma05 deleted the fix/pin-carbon-versions branch December 4, 2023 12:01
@denniskigen
Copy link
Member Author

For folks following this thread, this attempted fix did not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasharma05 vasharma05 vasharma05 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@denniskigen @vasharma05