Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) O3-2625: Adjust snackbar container position #832

Merged
merged 3 commits into from
Dec 4, 2023
Merged

(fix) O3-2625: Adjust snackbar container position #832

merged 3 commits into from
Dec 4, 2023

Conversation

hadijahkyampeire
Copy link
Contributor

@hadijahkyampeire hadijahkyampeire commented Dec 4, 2023 •
edited by denniskigen

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

This fix adjusts the vertical position of the snack bar container in tablet mode so it's not covered by the side rail. It does so by upping its bottom positional property value to 5.5rem so that the element gets positioned 5.5rem above the page's bottom margin.

Screenshots

Bug

Screenshot 2023-12-04 at 15 01 35

Fix

snackbar-in-table-mode.mov

Related Issue

Other

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2023 •
edited

Size Change: -371 kB (-12%) 👏

Total Size: 2.62 MB

Filename Size Change
packages/apps/esm-implementer-tools-app/dist/285.js 0 B -60.8 kB (removed) 🏆
packages/framework/esm-framework/dist/openmrs-esm-framework.js 374 kB -378 kB (-50%) 🏆
packages/shell/esm-app-shell/dist/openmrs.ec61c2246005ff04.js 0 B -332 kB (removed) 🏆
packages/apps/esm-implementer-tools-app/dist/79.js 60.8 kB +60.8 kB (new file) 🆕
packages/shell/esm-app-shell/dist/openmrs.c76d6f8a9f36f3a2.js 332 kB +332 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
packages/apps/esm-devtools-app/dist/68.js 4.66 kB 0 B
packages/apps/esm-devtools-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-devtools-app/dist/889.js 107 kB 0 B
packages/apps/esm-devtools-app/dist/988.js 282 B 0 B
packages/apps/esm-devtools-app/dist/main.js 2.95 kB 0 B
packages/apps/esm-devtools-app/dist/openmrs-esm-devtools-app.js 3.03 kB 0 B
packages/apps/esm-implementer-tools-app/dist/263.js 0 B -6.66 kB (removed) 🏆
packages/apps/esm-implementer-tools-app/dist/319.js 633 B 0 B
packages/apps/esm-implementer-tools-app/dist/329.js 10 kB 0 B
packages/apps/esm-implementer-tools-app/dist/426.js 1.66 kB +1 B (0%)
packages/apps/esm-implementer-tools-app/dist/460.js 735 B 0 B
packages/apps/esm-implementer-tools-app/dist/56.js 3.07 kB 0 B
packages/apps/esm-implementer-tools-app/dist/560.js 9.6 kB 0 B
packages/apps/esm-implementer-tools-app/dist/574.js 560 B 0 B
packages/apps/esm-implementer-tools-app/dist/587.js 2.81 kB 0 B
packages/apps/esm-implementer-tools-app/dist/620.js 126 kB 0 B
packages/apps/esm-implementer-tools-app/dist/625.js 562 B 0 B
packages/apps/esm-implementer-tools-app/dist/727.js 32.9 kB 0 B
packages/apps/esm-implementer-tools-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-implementer-tools-app/dist/757.js 560 B 0 B
packages/apps/esm-implementer-tools-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-implementer-tools-app/dist/807.js 559 B 0 B
packages/apps/esm-implementer-tools-app/dist/833.js 681 B 0 B
packages/apps/esm-implementer-tools-app/dist/889.js 107 kB 0 B
packages/apps/esm-implementer-tools-app/dist/main.js 72.9 kB +35 B (0%)
packages/apps/esm-implementer-tools-app/dist/openmrs-esm-implementer-tools-app.js 3.3 kB -6 B (0%)
packages/apps/esm-login-app/dist/111.js 1.22 kB 0 B
packages/apps/esm-login-app/dist/126.js 2.5 kB 0 B
packages/apps/esm-login-app/dist/173.js 1.22 kB 0 B
packages/apps/esm-login-app/dist/224.js 256 B 0 B
packages/apps/esm-login-app/dist/236.js 272 B 0 B
packages/apps/esm-login-app/dist/240.js 364 B 0 B
packages/apps/esm-login-app/dist/263.js 0 B -6.65 kB (removed) 🏆
packages/apps/esm-login-app/dist/272.js 264 B 0 B
packages/apps/esm-login-app/dist/319.js 692 B 0 B
packages/apps/esm-login-app/dist/336.js 234 B 0 B
packages/apps/esm-login-app/dist/370.js 30.4 kB 0 B
packages/apps/esm-login-app/dist/460.js 782 B 0 B
packages/apps/esm-login-app/dist/539.js 298 B 0 B
packages/apps/esm-login-app/dist/56.js 3.06 kB 0 B
packages/apps/esm-login-app/dist/574.js 609 B 0 B
packages/apps/esm-login-app/dist/625.js 600 B 0 B
packages/apps/esm-login-app/dist/627.js 257 B 0 B
packages/apps/esm-login-app/dist/63.js 16.5 kB 0 B
packages/apps/esm-login-app/dist/644.js 305 B 0 B
packages/apps/esm-login-app/dist/673.js 284 B 0 B
packages/apps/esm-login-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-login-app/dist/757.js 698 B 0 B
packages/apps/esm-login-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-login-app/dist/807.js 961 B 0 B
packages/apps/esm-login-app/dist/812.js 22.5 kB 0 B
packages/apps/esm-login-app/dist/833.js 727 B 0 B
packages/apps/esm-login-app/dist/889.js 107 kB 0 B
packages/apps/esm-login-app/dist/main.js 56.8 kB 0 B
packages/apps/esm-login-app/dist/openmrs-esm-login-app.js 3.32 kB +1 B (0%)
packages/apps/esm-offline-tools-app/dist/102.js 81.3 kB 0 B
packages/apps/esm-offline-tools-app/dist/193.js 55 kB -27 B (0%)
packages/apps/esm-offline-tools-app/dist/263.js 0 B -6.66 kB (removed) 🏆
packages/apps/esm-offline-tools-app/dist/319.js 1.14 kB 0 B
packages/apps/esm-offline-tools-app/dist/460.js 1.32 kB 0 B
packages/apps/esm-offline-tools-app/dist/56.js 3.07 kB 0 B
packages/apps/esm-offline-tools-app/dist/574.js 1.04 kB 0 B
packages/apps/esm-offline-tools-app/dist/625.js 1.04 kB 0 B
packages/apps/esm-offline-tools-app/dist/63.js 16.5 kB 0 B
packages/apps/esm-offline-tools-app/dist/735.js 2.63 kB 0 B
packages/apps/esm-offline-tools-app/dist/757.js 1.2 kB 0 B
packages/apps/esm-offline-tools-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-offline-tools-app/dist/807.js 1.1 kB 0 B
packages/apps/esm-offline-tools-app/dist/833.js 1.22 kB 0 B
packages/apps/esm-offline-tools-app/dist/889.js 107 kB 0 B
packages/apps/esm-offline-tools-app/dist/main.js 136 kB -20 B (0%)
packages/apps/esm-offline-tools-app/dist/openmrs-esm-offline-tools-app.js 3.29 kB +3 B (0%)
packages/apps/esm-primary-navigation-app/dist/262.js 13.3 kB 0 B
packages/apps/esm-primary-navigation-app/dist/263.js 0 B -6.66 kB (removed) 🏆
packages/apps/esm-primary-navigation-app/dist/319.js 200 B 0 B
packages/apps/esm-primary-navigation-app/dist/460.js 217 B 0 B
packages/apps/esm-primary-navigation-app/dist/574.js 183 B 0 B
packages/apps/esm-primary-navigation-app/dist/625.js 184 B 0 B
packages/apps/esm-primary-navigation-app/dist/63.js 16.5 kB 0 B
packages/apps/esm-primary-navigation-app/dist/735.js 18.7 kB 0 B
packages/apps/esm-primary-navigation-app/dist/757.js 209 B 0 B
packages/apps/esm-primary-navigation-app/dist/788.js 42.9 kB 0 B
packages/apps/esm-primary-navigation-app/dist/807.js 235 B 0 B
packages/apps/esm-primary-navigation-app/dist/833.js 210 B 0 B
packages/apps/esm-primary-navigation-app/dist/889.js 107 kB 0 B
packages/apps/esm-primary-navigation-app/dist/960.js 2.64 kB 0 B
packages/apps/esm-primary-navigation-app/dist/main.js 33.7 kB +3 B (0%)
packages/apps/esm-primary-navigation-app/dist/openmrs-esm-primary-navigation-app.js 3.23 kB +2 B (0%)
packages/framework/esm-api/dist/openmrs-esm-api.js 9.75 kB 0 B
packages/framework/esm-breadcrumbs/dist/openmrs-esm-breadcrumbs.js 2.66 kB 0 B
packages/framework/esm-config/dist/openmrs-esm-module-config.js 7.87 kB 0 B
packages/framework/esm-dynamic-loading/dist/openmrs-esm-dynamic-loading.js 2.12 kB 0 B
packages/framework/esm-error-handling/dist/openmrs-esm-error-handling.js 894 B 0 B
packages/framework/esm-extensions/dist/openmrs-esm-extensions.js 8.05 kB 0 B
packages/framework/esm-feature-flags/dist/openmrs-esm-feature-flags.js 1.67 kB 0 B
packages/framework/esm-framework/dist/146.openmrs-esm-framework.js 0 B -6.69 kB (removed) 🏆
packages/framework/esm-framework/dist/455.openmrs-esm-framework.js 4.57 kB 0 B
packages/framework/esm-framework/dist/530.openmrs-esm-framework.js 2.92 kB 0 B
packages/framework/esm-framework/dist/645.openmrs-esm-framework.js 9.31 kB 0 B
packages/framework/esm-framework/dist/710.openmrs-esm-framework.js 6.48 kB 0 B
packages/framework/esm-framework/dist/735.openmrs-esm-framework.js 2.66 kB 0 B
packages/framework/esm-framework/dist/788.openmrs-esm-framework.js 42.9 kB 0 B
packages/framework/esm-globals/dist/openmrs-esm-globals.js 756 B 0 B
packages/framework/esm-offline/dist/openmrs-esm-offline.js 34.4 kB 0 B
packages/framework/esm-react-utils/dist/openmrs-esm-react-utils.js 15.2 kB 0 B
packages/framework/esm-state/dist/openmrs-esm-state.js 888 B 0 B
packages/framework/esm-styleguide/dist/openmrs-esm-styleguide.js 19.3 kB 0 B
packages/framework/esm-utils/dist/openmrs-esm-utils.js 11 kB 0 B
packages/shell/esm-app-shell/dist/25018673bc6f380f.js 0 B -6.03 kB (removed) 🏆
packages/shell/esm-app-shell/dist/498a8af91d44612e.js 0 B -4.1 kB (removed) 🏆
packages/shell/esm-app-shell/dist/966c4dfec919951f.js 1.58 kB 0 B
packages/shell/esm-app-shell/dist/service-worker.js 60.5 kB +107 B (0%)
packages/tooling/openmrs/dist/cli.js 3.09 kB 0 B
packages/tooling/openmrs/dist/commands/assemble.js 2.73 kB 0 B
packages/tooling/openmrs/dist/commands/build.js 1.66 kB 0 B
packages/tooling/openmrs/dist/commands/debug.js 579 B 0 B
packages/tooling/openmrs/dist/commands/develop.js 1.86 kB 0 B
packages/tooling/openmrs/dist/commands/index.js 438 B 0 B
packages/tooling/openmrs/dist/commands/start.js 848 B 0 B
packages/tooling/openmrs/dist/index.js 517 B 0 B
packages/tooling/openmrs/dist/runner.js 870 B 0 B
packages/tooling/openmrs/dist/utils/config.js 726 B 0 B
packages/tooling/openmrs/dist/utils/debugger.js 529 B 0 B
packages/tooling/openmrs/dist/utils/dependencies.js 639 B 0 B
packages/tooling/openmrs/dist/utils/helpers.js 393 B 0 B
packages/tooling/openmrs/dist/utils/importmap.js 3.25 kB 0 B
packages/tooling/openmrs/dist/utils/index.js 444 B 0 B
packages/tooling/openmrs/dist/utils/logger.js 234 B 0 B
packages/tooling/openmrs/dist/utils/npmConfig.js 854 B 0 B
packages/tooling/openmrs/dist/utils/untar.js 721 B 0 B
packages/tooling/openmrs/dist/utils/variables.js 192 B 0 B
packages/tooling/openmrs/dist/utils/webpack.js 276 B 0 B
packages/tooling/webpack-config/dist/index.js 3.58 kB 0 B
packages/apps/esm-implementer-tools-app/dist/651.js 6.86 kB +6.86 kB (new file) 🆕
packages/apps/esm-implementer-tools-app/dist/738.js 6.79 kB +6.79 kB (new file) 🆕
packages/apps/esm-login-app/dist/729.js 6.78 kB +6.78 kB (new file) 🆕
packages/apps/esm-offline-tools-app/dist/729.js 6.79 kB +6.79 kB (new file) 🆕
packages/apps/esm-primary-navigation-app/dist/729.js 6.79 kB +6.79 kB (new file) 🆕
packages/framework/esm-framework/dist/655.openmrs-esm-framework.js 6.83 kB +6.83 kB (new file) 🆕
packages/shell/esm-app-shell/dist/b66a463116735f62.js 3.81 kB +3.81 kB (new file) 🆕
packages/shell/esm-app-shell/dist/fca8d09359d3b887.js 6.03 kB +6.03 kB (new file) 🆕

compressed-size-action

@hadijahkyampeire hadijahkyampeire changed the title (fix) O3-2625: Increase the snackbar container z-index (fix) O3-2625: Increase the margin-bottom of the snackbar container in tablet mode Dec 4, 2023
@denniskigen denniskigen changed the title (fix) O3-2625: Increase the margin-bottom of the snackbar container in tablet mode (fix) O3-2625: Adjust snackbar container position Dec 4, 2023
denniskigen
denniskigen approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, @hadijahkyampeire!

@denniskigen denniskigen merged commit f904208 into main Dec 4, 2023
9 checks passed
@denniskigen denniskigen deleted the fix-snackbar-zindex branch December 4, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denniskigen denniskigen denniskigen approved these changes

@vasharma05 vasharma05 Awaiting requested review from vasharma05

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@hadijahkyampeire @denniskigen