-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) allow useLocations react hook to take in tag parameter #849
Conversation
Size Change: -332 kB (-11%) 👏 Total Size: 2.71 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @chibongho ! Genrerally LGTM, what's up with those SnackarDescriptor name changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, same comment as @mogoodrich about the Snackbar file changes that appear
The git commit hook changed the casing of those file names. |
These are fine. The pre-commit hook runs a task that updates the markdown files that updates our API docs. They likely got updated in a previous commit that @chibongho might not have had on his local. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @chibongho. Thanks! Possible future improvements to this code would better type annotations and possibly refactoring getLocations
to use just one pipe
invocation.
Requirements
feat
,fix
, orchore
, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
We currently have a
useLocations()
hook which calls the v1 REST API for a list of locations. The REST API can already take in an additional parameter to specify a tag to filter by all locations with that tag. This PR changes the hook to support passing a tag parameter.Screenshots
Related Issue
Other
Note that the git commit hook generated some styling and documentation changes that I had to manually re-add into the commit.