(fix) O3-2694: fixed form display when RTL language is selected #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherrif10
reviewed
Jan 4, 2024
| @@ -483,14 +487,33 @@ html[dir='rtl'] { | |||
| } | |||
| } | |||
| } | |||
| .tab-content { | |||
| margin-left: unset; | |||
There was a problem hiding this comment.
You would add this fix in this openmrs/openmrs-esm-patient-chart#1561.
There was a problem hiding this comment.
I don't think so, to overwrite from there I would need to disable the Angular scope encapsulation: ViewEncapsulation.None which is error prone and all the RTL related styles are already posted here
ibacher
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
feat,fix, orchore, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
Fixed form display when RTL language is selected
Screenshots
Related Issue
O3-2694