(fix) Make navbar not re-render like crazy (fixes O3-2692)

[brandones]

Requirements

• This PR has a title that briefly describes the work done including the ticket number. Ensure your PR title includes a conventional commit label (such as feat, fix, or chore, among others). See existing PR titles for inspiration.

For changes to apps

• My work conforms to the O3 Styleguide and design documentation.

If applicable

• My work includes tests or is validated by existing tests.
• I have updated the esm-framework mock to reflect any API changes I have made.

Summary

You know how the right side of the navbar has been blinky for a long time and we all kind of assumed it was a tricky extension thing?

blinky-nonsense.mp4

It was actually just a classic React "don't define a component within another component" issue.

This gets rid of all the visual glitching, unmounting/remounting, etc. shown above.

It also fixes https://openmrs.atlassian.net/browse/O3-2692 "Two errors on logout: person is undefined and Language ID should be string or object," which was caused by an extension within the user panel not getting unmounted when it should, which somehow was being caused by the erratic re-rendering behavior of the navbar, in which its slot was contained.

NB: Yes, this does indicate that there is a subtle bug in the extension system that can cause extensions to fail to be unmounted if there is a chaotic amount of churn. I haven't solved that. But hopefully we just don't have churn.

Screenshots

navbar-fix.mp4

Related Issue

https://openmrs.atlassian.net/browse/O3-2692

[github-actions]

Size Change: -100 B (0%)

Total Size: 2.75 MB

ℹ️ View Unchanged

Filename	Size	Change
packages/apps/esm-devtools-app/dist/630.js	2.69 kB	0 B
packages/apps/esm-devtools-app/dist/729.js	6.79 kB	0 B
packages/apps/esm-devtools-app/dist/735.js	2.63 kB	0 B
packages/apps/esm-devtools-app/dist/788.js	42.9 kB	0 B
packages/apps/esm-devtools-app/dist/875.js	9.76 kB	0 B
packages/apps/esm-devtools-app/dist/889.js	109 kB	0 B
packages/apps/esm-devtools-app/dist/961.js	25.3 kB	0 B
packages/apps/esm-devtools-app/dist/988.js	328 B	0 B
packages/apps/esm-devtools-app/dist/main.js	3.14 kB	0 B
packages/apps/esm-devtools-app/dist/openmrs-esm-devtools-app.js	3.18 kB	0 B
packages/apps/esm-implementer-tools-app/dist/319.js	633 B	0 B
packages/apps/esm-implementer-tools-app/dist/426.js	1.66 kB	0 B
packages/apps/esm-implementer-tools-app/dist/460.js	735 B	0 B
packages/apps/esm-implementer-tools-app/dist/56.js	3.07 kB	0 B
packages/apps/esm-implementer-tools-app/dist/560.js	9.61 kB	0 B
packages/apps/esm-implementer-tools-app/dist/574.js	560 B	0 B
packages/apps/esm-implementer-tools-app/dist/587.js	2.92 kB	0 B
packages/apps/esm-implementer-tools-app/dist/620.js	126 kB	0 B
packages/apps/esm-implementer-tools-app/dist/625.js	562 B	0 B
packages/apps/esm-implementer-tools-app/dist/651.js	6.86 kB	0 B
packages/apps/esm-implementer-tools-app/dist/727.js	33 kB	0 B
packages/apps/esm-implementer-tools-app/dist/735.js	2.63 kB	0 B
packages/apps/esm-implementer-tools-app/dist/738.js	6.79 kB	0 B
packages/apps/esm-implementer-tools-app/dist/757.js	560 B	0 B
packages/apps/esm-implementer-tools-app/dist/767.js	10.4 kB	0 B
packages/apps/esm-implementer-tools-app/dist/788.js	42.9 kB	0 B
packages/apps/esm-implementer-tools-app/dist/807.js	559 B	0 B
packages/apps/esm-implementer-tools-app/dist/833.js	681 B	0 B
packages/apps/esm-implementer-tools-app/dist/889.js	109 kB	0 B
packages/apps/esm-implementer-tools-app/dist/913.js	61.2 kB	0 B
packages/apps/esm-implementer-tools-app/dist/main.js	73.3 kB	0 B
packages/apps/esm-implementer-tools-app/dist/openmrs-esm-implementer-tools-app.js	3.3 kB	0 B
packages/apps/esm-login-app/dist/111.js	1.22 kB	0 B
packages/apps/esm-login-app/dist/126.js	2.5 kB	0 B
packages/apps/esm-login-app/dist/173.js	1.22 kB	0 B
packages/apps/esm-login-app/dist/224.js	256 B	0 B
packages/apps/esm-login-app/dist/236.js	272 B	0 B
packages/apps/esm-login-app/dist/240.js	364 B	0 B
packages/apps/esm-login-app/dist/272.js	264 B	0 B
packages/apps/esm-login-app/dist/319.js	692 B	0 B
packages/apps/esm-login-app/dist/336.js	234 B	0 B
packages/apps/esm-login-app/dist/363.js	30.1 kB	-70 B (0%)
packages/apps/esm-login-app/dist/460.js	782 B	0 B
packages/apps/esm-login-app/dist/539.js	298 B	0 B
packages/apps/esm-login-app/dist/56.js	3.06 kB	0 B
packages/apps/esm-login-app/dist/574.js	609 B	0 B
packages/apps/esm-login-app/dist/625.js	600 B	0 B
packages/apps/esm-login-app/dist/627.js	257 B	0 B
packages/apps/esm-login-app/dist/63.js	16.5 kB	0 B
packages/apps/esm-login-app/dist/644.js	305 B	0 B
packages/apps/esm-login-app/dist/673.js	284 B	0 B
packages/apps/esm-login-app/dist/729.js	6.78 kB	0 B
packages/apps/esm-login-app/dist/735.js	2.63 kB	0 B
packages/apps/esm-login-app/dist/757.js	698 B	0 B
packages/apps/esm-login-app/dist/788.js	42.9 kB	0 B
packages/apps/esm-login-app/dist/807.js	961 B	0 B
packages/apps/esm-login-app/dist/833.js	727 B	0 B
packages/apps/esm-login-app/dist/836.js	22.5 kB	0 B
packages/apps/esm-login-app/dist/889.js	109 kB	0 B
packages/apps/esm-login-app/dist/main.js	56.5 kB	-76 B (0%)
packages/apps/esm-login-app/dist/openmrs-esm-login-app.js	3.32 kB	0 B
packages/apps/esm-offline-tools-app/dist/319.js	1.14 kB	0 B
packages/apps/esm-offline-tools-app/dist/430.js	55.4 kB	0 B
packages/apps/esm-offline-tools-app/dist/460.js	1.32 kB	0 B
packages/apps/esm-offline-tools-app/dist/56.js	3.07 kB	0 B
packages/apps/esm-offline-tools-app/dist/574.js	1.04 kB	0 B
packages/apps/esm-offline-tools-app/dist/625.js	1.04 kB	0 B
packages/apps/esm-offline-tools-app/dist/63.js	16.5 kB	0 B
packages/apps/esm-offline-tools-app/dist/729.js	6.79 kB	0 B
packages/apps/esm-offline-tools-app/dist/735.js	2.63 kB	0 B
packages/apps/esm-offline-tools-app/dist/757.js	1.2 kB	0 B
packages/apps/esm-offline-tools-app/dist/788.js	42.9 kB	0 B
packages/apps/esm-offline-tools-app/dist/807.js	1.1 kB	0 B
packages/apps/esm-offline-tools-app/dist/833.js	1.22 kB	0 B
packages/apps/esm-offline-tools-app/dist/889.js	109 kB	0 B
packages/apps/esm-offline-tools-app/dist/922.js	81.2 kB	0 B
packages/apps/esm-offline-tools-app/dist/main.js	136 kB	0 B
packages/apps/esm-offline-tools-app/dist/openmrs-esm-offline-tools-app.js	3.29 kB	0 B
packages/apps/esm-primary-navigation-app/dist/319.js	218 B	0 B
packages/apps/esm-primary-navigation-app/dist/34.js	21.1 kB	0 B
packages/apps/esm-primary-navigation-app/dist/460.js	240 B	0 B
packages/apps/esm-primary-navigation-app/dist/574.js	205 B	0 B
packages/apps/esm-primary-navigation-app/dist/625.js	207 B	0 B
packages/apps/esm-primary-navigation-app/dist/63.js	16.5 kB	0 B
packages/apps/esm-primary-navigation-app/dist/729.js	6.79 kB	0 B
packages/apps/esm-primary-navigation-app/dist/735.js	2.64 kB	0 B
packages/apps/esm-primary-navigation-app/dist/757.js	217 B	0 B
packages/apps/esm-primary-navigation-app/dist/762.js	7.29 kB	0 B
packages/apps/esm-primary-navigation-app/dist/788.js	42.9 kB	0 B
packages/apps/esm-primary-navigation-app/dist/807.js	274 B	0 B
packages/apps/esm-primary-navigation-app/dist/833.js	237 B	0 B
packages/apps/esm-primary-navigation-app/dist/889.js	109 kB	0 B
packages/apps/esm-primary-navigation-app/dist/958.js	22 kB	+18 B (0%)
packages/apps/esm-primary-navigation-app/dist/main.js	44.7 kB	+28 B (0%)
packages/apps/esm-primary-navigation-app/dist/openmrs-esm-primary-navigation-app.js	3.23 kB	0 B
packages/framework/esm-api/dist/openmrs-esm-api.js	10 kB	0 B
packages/framework/esm-breadcrumbs/dist/openmrs-esm-breadcrumbs.js	2.66 kB	0 B
packages/framework/esm-config/dist/openmrs-esm-module-config.js	7.87 kB	0 B
packages/framework/esm-dynamic-loading/dist/openmrs-esm-dynamic-loading.js	2.12 kB	0 B
packages/framework/esm-error-handling/dist/openmrs-esm-error-handling.js	894 B	0 B
packages/framework/esm-extensions/dist/openmrs-esm-extensions.js	8.05 kB	0 B
packages/framework/esm-feature-flags/dist/openmrs-esm-feature-flags.js	1.67 kB	0 B
packages/framework/esm-framework/dist/455.openmrs-esm-framework.js	4.57 kB	0 B
packages/framework/esm-framework/dist/530.openmrs-esm-framework.js	2.92 kB	0 B
packages/framework/esm-framework/dist/645.openmrs-esm-framework.js	9.31 kB	0 B
packages/framework/esm-framework/dist/655.openmrs-esm-framework.js	6.83 kB	0 B
packages/framework/esm-framework/dist/710.openmrs-esm-framework.js	6.48 kB	0 B
packages/framework/esm-framework/dist/735.openmrs-esm-framework.js	2.66 kB	0 B
packages/framework/esm-framework/dist/788.openmrs-esm-framework.js	42.9 kB	0 B
packages/framework/esm-framework/dist/openmrs-esm-framework.js	376 kB	0 B
packages/framework/esm-globals/dist/openmrs-esm-globals.js	756 B	0 B
packages/framework/esm-offline/dist/openmrs-esm-offline.js	34.4 kB	0 B
packages/framework/esm-react-utils/dist/openmrs-esm-react-utils.js	15.4 kB	0 B
packages/framework/esm-routes/dist/openmrs-esm-utils.js	1.46 kB	0 B
packages/framework/esm-state/dist/openmrs-esm-state.js	888 B	0 B
packages/framework/esm-styleguide/dist/openmrs-esm-styleguide.js	19.3 kB	0 B
packages/framework/esm-utils/dist/openmrs-esm-utils.js	11.2 kB	0 B
packages/shell/esm-app-shell/dist/08a99d285a4ddb28.js	6.45 kB	0 B
packages/shell/esm-app-shell/dist/695f23c4e6b3f009.js	1.58 kB	0 B
packages/shell/esm-app-shell/dist/b66a463116735f62.js	3.81 kB	0 B
packages/shell/esm-app-shell/dist/openmrs.80ae95cc52ad28a6.js	334 kB	0 B
packages/shell/esm-app-shell/dist/service-worker.js	60.5 kB	0 B
packages/tooling/openmrs/dist/cli.js	2.85 kB	0 B
packages/tooling/openmrs/dist/commands/assemble.js	2.4 kB	0 B
packages/tooling/openmrs/dist/commands/build.js	1.34 kB	0 B
packages/tooling/openmrs/dist/commands/debug.js	545 B	0 B
packages/tooling/openmrs/dist/commands/develop.js	2.59 kB	0 B
packages/tooling/openmrs/dist/commands/index.js	438 B	0 B
packages/tooling/openmrs/dist/commands/start.js	851 B	0 B
packages/tooling/openmrs/dist/index.js	517 B	0 B
packages/tooling/openmrs/dist/runner.js	637 B	0 B
packages/tooling/openmrs/dist/utils/config.js	728 B	0 B
packages/tooling/openmrs/dist/utils/debugger.js	576 B	0 B
packages/tooling/openmrs/dist/utils/dependencies.js	648 B	0 B
packages/tooling/openmrs/dist/utils/helpers.js	395 B	0 B
packages/tooling/openmrs/dist/utils/importmap.js	3.07 kB	0 B
packages/tooling/openmrs/dist/utils/index.js	444 B	0 B
packages/tooling/openmrs/dist/utils/logger.js	368 B	0 B
packages/tooling/openmrs/dist/utils/npmConfig.js	830 B	0 B
packages/tooling/openmrs/dist/utils/untar.js	722 B	0 B
packages/tooling/openmrs/dist/utils/variables.js	192 B	0 B
packages/tooling/openmrs/dist/utils/webpack.js	278 B	0 B
packages/tooling/webpack-config/dist/index.js	3.58 kB	0 B

_{compressed-size-action}