Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) Add chinese language files #879

Merged
merged 10 commits into from
Jan 16, 2024
Merged

(chore) Add chinese language files #879

merged 10 commits into from
Jan 16, 2024

Conversation

jona42-ui
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. Ensure your PR title includes a conventional commit label (such as feat, fix, or chore, among others). See existing PR titles for inspiration.

For changes to apps

@jona42-ui jona42-ui changed the title (Chore)Add the language files (Chore)Add chinese language files Jan 10, 2024
@jona42-ui
Copy link
Contributor Author

cc @ibacher @rbuisson

@ibacher ibacher changed the title (Chore)Add chinese language files (chore) Add chinese language files Jan 12, 2024
@ibacher
Copy link
Member

ibacher commented Jan 12, 2024

@jona42-ui It's also necessary to modify the file here to include the new locales.

@jona42-ui
Copy link
Contributor Author

updated thanks @ibacher

Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jona42-ui. This LGTM. Do we also need zh_CN translations, @ibacher, https://github.com/befantasy?

@ibacher ibacher merged commit ece61c4 into openmrs:main Jan 16, 2024
7 checks passed
@ibacher
Copy link
Member

ibacher commented Jan 16, 2024

@denniskigen We can always add them later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants