-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) Add ResponsiveWrapper to style guide #909
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +9 B (0%) Total Size: 2.85 MB
ℹ️ View Unchanged
|
ibacher
approved these changes
Jan 29, 2024
Very nice work! |
Thanks, @ibacher. |
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
feat
,fix
, orchore
, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
This PR adds a new component,
ResponsiveWrapper
to the style guide that makes it easier to provide responsive behaviour for form inputs.In our form designs, inputs have a light background on tablet and a grey background on desktop. This component wraps its children within a Carbon Layer component on tablet, and renders them as is on desktop. In older versions of carbon, form inputs such as
TextInput
,NumberInput
andTextarea
exposed alight
prop that could be used to toggle similar behaviour. v11 of Carbon deprecated thelight
prop in favour of theLayer
component. This component leveragesLayer
to provide consistent rendering behaviour on both desktop and tablet.I'd originally added this component to the
@openmrs/esm-patient-common-lib
library in openmrs/openmrs-esm-patient-chart#1622, but it seems more appropriate to have it here as it'll likely be used in many other places than just the Patient Chart.Screenshots
Light inputs on tablet, gray inputs on desktop
Related Issue
None
Other
None