Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) O3-2733: Automatically close header panels on panel selection #912

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

jwnasambu
Copy link
Contributor

@jwnasambu jwnasambu commented Jan 31, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. Ensure your PR title includes a conventional commit label (such as feat, fix, or chore, among others). See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

I modified the code when the Menu" button is clicked, it toggles the visibility of the "App Menu" or Use Menu panel after a short delay and displays either a close button or a switcher icon based on the current state of the panel. The delay is introduced to allow any animations or transitions to complete before changing the panel's visibility.

Screenshots

Before

Kapture.2024-01-26.at.01.17.38.mp4

After fixing

screencast.2024-02-01.1.AM-24-03.mp4

Related Issue

https://openmrs.atlassian.net/browse/O3-2733

Other

@jwnasambu jwnasambu changed the title Enhance primary navigation by automatically closing header panels on panel selection (fix)O3-2733: Automatically close header panels on panel selection Jan 31, 2024
@ibacher
Copy link
Member

ibacher commented Feb 1, 2024

Thanks @jwnasambu! I've simplified the PR to it's bare essence.

@ibacher ibacher changed the title (fix)O3-2733: Automatically close header panels on panel selection (fix) O3-2733: Automatically close header panels on panel selection Feb 1, 2024
@ibacher ibacher merged commit 9afd854 into openmrs:main Feb 1, 2024
8 checks passed
@denniskigen
Copy link
Member

Nicely done! Thank you both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants