Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v5.4.0 #918

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Release v5.4.0 #918

merged 1 commit into from
Feb 8, 2024

Conversation

jayasanka-sack
Copy link
Member

@jayasanka-sack jayasanka-sack commented Feb 7, 2024 •
edited

Release v5.4.0

vasharma05
vasharma05 approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@vasharma05 vasharma05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jayasanka-sack!

@denniskigen
Copy link
Member

denniskigen commented Feb 8, 2024 •
edited

@jayasanka-sack, LGTM save for a minor detail about release commits for Core: the commit message should match the format (chore) Release x.x.x so the CI knows to skip running the pre-release job https://github.com/openmrs/openmrs-esm-core?tab=readme-ov-file#version-and-release

@jayasanka-sack
Copy link
Member Author

Oh, thanks for pointing it out. I'll add it when merging the PR.

@jayasanka-sack jayasanka-sack merged commit acaf5dc into openmrs:main Feb 8, 2024
8 checks passed
@jayasanka-sack jayasanka-sack deleted the v5.4.0 branch February 8, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denniskigen denniskigen denniskigen approved these changes

@vasharma05 vasharma05 vasharma05 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jayasanka-sack @denniskigen @vasharma05