Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(chore) Bump playwright #950

Merged
merged 1 commit into from
Mar 8, 2024
Merged

(chore) Bump playwright #950

merged 1 commit into from
Mar 8, 2024

Conversation

kdaud
Copy link
Member

@kdaud kdaud commented Mar 6, 2024 •
edited

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. Ensure your PR title includes a conventional commit label (such as feat, fix, or chore, among others). See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

This PR upgrades playwright to the latest version 1.42.1. See release notes at https://playwright.dev/docs/release-notes

Screenshots

Related Issue

Other

@kdaud kdaud marked this pull request as ready for review March 6, 2024 12:42
@kdaud
Copy link
Member Author

kdaud commented Mar 6, 2024 •
edited

Take care: This PR should not be merged until E2E tests run and pass on the upped playwright version.

denniskigen
denniskigen approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kdaud!

@denniskigen denniskigen merged commit 3f9138c into openmrs:main Mar 8, 2024
8 checks passed
@kdaud kdaud deleted the Upping branch May 8, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denniskigen denniskigen denniskigen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kdaud @denniskigen