(fix) O3-2489 - toDateObjectStrict returns null if the passed string is not considered a valid date #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… considered a valid date Making sure the toDateObjectString function fails when a null date is passed
… considered a valid date Making sure the toDateObjectString function fails when a null date is passed
… considered a valid date 1 Making sure the toDateObjectString function fails when a null date is passed
… considered a valid date Making sure the toDateObjectString throws an error when a none supported date is passed to it.
|
Do not delete the PR template; fill it in. Follow the instructions. I have added the template back in and filled it in for you. For your code, delete the comment and write some tests. |
brandones
changed the title
brandones
changed the title
brandones
reviewed
Apr 19, 2024
Comment on lines
66
to
67
| // return null; | ||
| throw new Error(`The date "${omrsDateString}" is not valid. This is a custom error to prevent null dates from being written in the database.`); |
There was a problem hiding this comment.
Suggested change
| // return null; | |
| throw new Error(`The date "${omrsDateString}" is not valid. This is a custom error to prevent null dates from being written in the database.`); | |
| throw new Error("`toDateObjectStrict` failed to parse date string "${omrsDateString}".`); |
… considered a valid date Making the `toDateObjectStrict` throw are more direct error message when an unsupported date is passed to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
feat,fix, orchore, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
This adds a custom error message to the 'toDateObjectString' when a non-valid date is passed into it as a 'omrsDateString'
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-2489
Other