-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(chore) O3-1514: Upgrade Yarn to berry #73
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Jexsie !
I've taken a look but with my lack of experience I'm not the best to ask... thanks @ibacher for taking a look, and I'll add @denniskigen as well...
I haven't been following this too closely, @Jexsie do you have more changes to make, or are you waiting for re-review from @denniskigen , @ibacher and @pirupius ? |
Should be good to go, @mogoodrich, I'd asked @ibacher to review it anew. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Cool, thanks @denniskigen and @ibacher ... @Jexsie I'll test tomorrow to make sure things are working for me and then I will close the ticket out, thanks again! |
Requirements
Summary
This PR migrates yarn from v1 to v3, in keeping with the rest of our frontend modules. It also:
yarn upgrade-interactive
for upgrading dependency versions.yarn install --immutable
in the primary CI workflow.dexie
package to themoduleNameMapper
entry of our Jest config.