Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) O3-1514: Upgrade Yarn to berry #73

Merged
merged 4 commits into from
May 18, 2023
Merged

(chore) O3-1514: Upgrade Yarn to berry #73

merged 4 commits into from
May 18, 2023

Conversation

Jexsie
Copy link
Contributor

@Jexsie Jexsie commented May 11, 2023

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR migrates yarn from v1 to v3, in keeping with the rest of our frontend modules. It also:

  • Adds the interactive tools plugin, enabling developers to leverage yarn upgrade-interactive for upgrading dependency versions.
  • Fixes a typo in the invocation of yarn install --immutable in the primary CI workflow.
  • Adds an entry for the dexie package to the moduleNameMapper entry of our Jest config.

@Jexsie
Copy link
Contributor Author

Jexsie commented May 11, 2023

cc @pirupius @mogoodrich

package.json Outdated Show resolved Hide resolved
Copy link
Member

@mogoodrich mogoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jexsie !

I've taken a look but with my lack of experience I'm not the best to ask... thanks @ibacher for taking a look, and I'll add @denniskigen as well...

package.json Outdated Show resolved Hide resolved
@mogoodrich
Copy link
Member

I haven't been following this too closely, @Jexsie do you have more changes to make, or are you waiting for re-review from @denniskigen , @ibacher and @pirupius ?

@denniskigen denniskigen changed the title (chore) O3-1514: Upgrade Yarn to berry (chore) O3-1514: Upgrade Yarn to berry May 18, 2023
@denniskigen
Copy link
Member

Should be good to go, @mogoodrich, I'd asked @ibacher to review it anew.

tsconfig.json Outdated Show resolved Hide resolved
Copy link
Member

@ibacher ibacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibacher ibacher merged commit 90dfd4b into main May 18, 2023
4 checks passed
@ibacher ibacher deleted the chore/yarn branch May 18, 2023 17:46
@mogoodrich
Copy link
Member

Cool, thanks @denniskigen and @ibacher ... @Jexsie I'll test tomorrow to make sure things are working for me and then I will close the ticket out, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants