Implement save form feature #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kumuditha-udayanga could you possibly update CI to deploy this to dev3? |
|
@jonathandick, I updated the deployment process |
|
@kumuditha-udayanga thanks for raising the PR, but can you annotate this PR with relevant attachments to visualise your changes? |
|
Hi @samuelmale thank you for reviewing, I updated the PR, attached few screenshots of the changes and a screen record link. |
|
@kumuditha-udayanga don't you think the form name can be inferred from the form json?
|
samuelmale
approved these changes
Aug 26, 2022
Comment on lines
54
to
67
| const openModal = (option) => { | ||
| if (option === "newVersion") { | ||
| setSaveState("newVersion"); | ||
| setOpenConfirmSaveModal(false); | ||
| setOpenSaveFormModal(true); | ||
| } else if (option === "new") { | ||
| setSaveState("newVersion"); | ||
| setOpenSaveFormModal(true); | ||
| } else if (option === "update") { | ||
| setSaveState("update"); | ||
| setOpenConfirmSaveModal(false); | ||
| setOpenSaveFormModal(true); | ||
| } | ||
| }; |
There was a problem hiding this comment.
I would wrap this in a useCallback
src/context/context.tsx
Outdated
| @@ -0,0 +1,3 @@ | |||
| import { createContext } from "react"; | |||
|
|
|||
| export const SchemaContext = createContext(null); | |||
There was a problem hiding this comment.
Can you define typings for the SchemaContext?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Screenshots
Demo on creating new forms
https://vimeo.com/738267453