Skip to content

Commit

Permalink
(chore) Upgrade Playwright version in Docker image (#1560)
Browse files Browse the repository at this point in the history
* (chore) Upgrade Playwright version in Docker image

* Update README
  • Loading branch information
denniskigen committed Jan 3, 2024
1 parent 516f991 commit 8e2fd5f
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,10 @@ yarn test-e2e

Read the [e2e testing guide](https://o3-docs.openmrs.org/docs/frontend-modules/testing) to learn more about End-to-End tests in this project.

### Updating Playwright

The Playwright version in the [Bamboo e2e Dockerfile](e2e/support/bamboo/playwright.Dockerfile#L2) and the `package.json` file must match. If you update the Playwright version in one place, you must update it in the other.

## Troubleshooting

If you notice that your local version of the application is not working or that there's a mismatch between what you see locally versus what's in [dev3](https://dev3.openmrs.org/openmrs/spa), you likely have outdated versions of core libraries. To update core libraries, run the following commands:
Expand Down
6 changes: 3 additions & 3 deletions e2e/support/bamboo/playwright.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
# The image version should match the Playwright version specified in the package.json file
FROM mcr.microsoft.com/playwright:v1.39.0-jammy
FROM mcr.microsoft.com/playwright:v1.40.1-jammy

ARG USER_ID
ARG GROUP_ID

RUN if ! getent group $GROUP_ID > /dev/null; then \
groupadd -g $GROUP_ID myusergroup; \
fi
groupadd -g $GROUP_ID myusergroup; \
fi

RUN useradd -u $USER_ID -g $GROUP_ID -m playwrightuser

Expand Down

0 comments on commit 8e2fd5f

Please sign in to comment.