Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O3-1679: Test results header in the "Test Results" dashboard appearing twice #1102

Merged
merged 4 commits into from
Apr 11, 2023
Merged

O3-1679: Test results header in the "Test Results" dashboard appearing twice #1102

merged 4 commits into from
Apr 11, 2023

Conversation

njiddasalifu
Copy link
Contributor

@njiddasalifu njiddasalifu commented Apr 6, 2023

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
    For changes to apps
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
    If applicable
  • My work includes tests or is validated by existing tests.

Summary

Patient test results title was duplicated as Test results and Results. The required title is Results only.

Screenshots

Before

before

After

after

Related Issue

https://issues.openmrs.org/browse/O3-1679

Other

@njiddasalifu
Copy link
Contributor Author

Hi @vasharma05 can you please review this PR

@njiddasalifu njiddasalifu changed the title O3 1679. Test results appearing twice on the page O3-1679: Test results appearing twice on the page Apr 10, 2023
@vasharma05 vasharma05 changed the title O3-1679: Test results appearing twice on the page O3-1679: Test results header in the "Test Results" dashboard appearing twice Apr 10, 2023
Copy link
Member

@vasharma05 vasharma05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Thanks!

@denniskigen
Copy link
Member

Thanks, @njiddasalifu!

@denniskigen denniskigen merged commit 5e5b873 into openmrs:main Apr 11, 2023
5 checks passed
@njiddasalifu
Copy link
Contributor Author

thank to you @denniskigen and @vasharma05 as well.

@njiddasalifu njiddasalifu deleted the O3-1679 branch April 12, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants