Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) KH-175 Fix regression Introduced by https://github.com/openmrs/openmrs-esm-patient-chart/pull/1042 #1136

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

enyachoke
Copy link
Collaborator

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR fixes a regression introduced last week which breaks form expressions that use sex. (#1042)

Screenshots

Related Issue

Other

@enyachoke
Copy link
Collaborator Author

enyachoke commented Apr 28, 2023

FYI @VivekAlladi, this https://github.com/VivekAlladi/openmrs-esm-patient-chart/blob/55f2e9710acee13be86df0c01efab00584814eee/packages/esm-form-entry-app/src/app/form-data-source/form-data-source.service.ts#L307-L319 does not do what you intended it to do. Or if this was the intention, please note that it breaks for expressions that expect to get back a gender string

Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @enyachoke.

@denniskigen denniskigen merged commit da565db into openmrs:main Apr 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants