-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(chore) Improve build efficiency of form-engine-app #1157
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -253 kB (-4%) Total Size: 6.3 MB
ℹ️ View Unchanged
|
denniskigen
approved these changes
May 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @ibacher.
donaldkibet
approved these changes
May 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
dependencies
. This should shrink the size of the built application and it's unnecessary here as @openmrs/esm-patient-common-lib can be resolved from the workspace.scriptRuleConfig.exclude
regex to actually do what it's intended to do instead of this. I think the current regex only works by mistake and likely causes additional libraries to be loaded by the SWC loader at build time.@openmrs/esm-framework/src/internal
which doesn't seem to be necessary or useful. I left the other aliases in place because I am not familiar with those libraries.While this will likely result in a larger code size reported by the automated tooling, it should actually result in a slightly smaller code size loaded for this app at runtime.
Screenshots
Related Issue
Other