Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Patient deceased widget should not break when patient is undefined #1160

Merged
merged 1 commit into from
May 17, 2023

Conversation

Jexsie
Copy link
Contributor

@Jexsie Jexsie commented May 17, 2023

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Screenshots

Related Issue

Other

@ibacher ibacher changed the title (breaking) Fix regression in 1148 (fix) Fix regression in 1148 May 17, 2023
@ibacher
Copy link
Member

ibacher commented May 17, 2023

This is a fix. "BREAKING" is reserved for where we are making code changes that change the API so that previous code no longer works. Everything else is either a (feat) if it adds new functionality without breaking existing functionality or, like this, a (fix) if it fixes a bug. Bugs are (maybe) breaking for the product, but the commit for them isn't.

@ibacher
Copy link
Member

ibacher commented May 17, 2023

Also, the title of the PR should reflect what the PR does (e.g., "deceased tag should render even if patient is undefined") rather than what code it effects. If you want to note that it fixes a regression introduced in a commit, add that as the second line of the commit message or just in the description of the ticket.

@ibacher ibacher changed the title (fix) Fix regression in 1148 (fix) Patient deceased widget should not break when patient is undefined May 17, 2023
@ibacher ibacher merged commit 8329ade into openmrs:main May 17, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants