Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) Add translation keys and strings for all the available dashboards in en.json , fr.json  and other locales #1171

Merged
merged 1 commit into from
May 23, 2023
Merged

(fix) Add translation keys and strings for all the available dashboards in en.json , fr.json  and other locales #1171

merged 1 commit into from
May 23, 2023

Conversation

jwnasambu
Copy link
Contributor

@jwnasambu jwnasambu commented May 23, 2023 •
edited

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

I added translation keys and strings for all the available dashboards in en.json and then translated their equivalents in fr.json and km.json

Screenshots

screencast.2023-05-23.6.PM-12-40.mp4

Related Issue

Its a follow-up ticket for this ticket #1155

Other

@jwnasambu
Copy link
Contributor Author

@denniskigen, @ibacher, @vasharma05, @Romain B, @mksd kindly help me review my PR at your convinient time please!

Jexsie
Jexsie approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@Jexsie Jexsie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @jwnasambu

@ibacher ibacher changed the title Add translation keys and strings for all the available dashboards in en.json , fr.json  and other locales (fix) Add translation keys and strings for all the available dashboards in en.json , fr.json  and other locales May 23, 2023
@ibacher ibacher merged commit 43f9cf8 into openmrs:main May 23, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibacher ibacher ibacher approved these changes

@Jexsie Jexsie Jexsie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@jwnasambu @ibacher @Jexsie @jwamalwa