-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) Implement the print functionality for Vitals lists #1196
Conversation
@hadijahkyampeire and @denniskigen kindly review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @nanfuka for the progress, just a few things plus good PR conventions. The title Print feature is too big, it should probably be (feat) Implement the print functionality for Vitals lists
.
Remember this print functionality is going to appear in many places, so the PR should have a title that clearly state exactly what it is changing.
packages/esm-patient-vitals-app/src/vitals/print-this.component.tsx
Outdated
Show resolved
Hide resolved
Also about the PR details, instead of linking to the wiki GSoC overview, please create tickets for all the expected print tickets in the OpenMRS 3.x board and always attach them to their specific PRs. That helps the review to know the PR requirements. Let me know if you need some guidance on that. |
packages/esm-patient-vitals-app/src/vitals/print-this.component.tsx
Outdated
Show resolved
Hide resolved
@nanfuka I don't see the header when I test the branch locally. Also please fix the failing tests. |
packages/esm-patient-vitals-app/src/vitals/paginated-vitals.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-vitals-app/src/vitals/paginated-vitals.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-vitals-app/src/vitals/print/print.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-vitals-app/src/vitals/vitals-overview.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-vitals-app/src/vitals/paginated-vitals.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-vitals-app/src/vitals/paginated-vitals.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-vitals-app/src/vitals/print/print.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-vitals-app/src/vitals/print/print.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-vitals-app/src/vitals/paginated-vitals.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-vitals-app/src/vitals/paginated-vitals.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-vitals-app/src/vitals/vitals-overview.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-vitals-app/src/vitals/paginated-vitals.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-vitals-app/src/vitals/vitals-overview.component.tsx
Outdated
Show resolved
Hide resolved
e3d2ed8
to
7bc95cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much @nanfuka for this great work, let's merge it and move forward.
Maybe best to get some final design feedback on today's squad call before merging. Also, please wait for an updated code review from me. |
4f18f07
to
c196ec7
Compare
c196ec7
to
b44d4c2
Compare
Good start, @nanfuka. Keen to see how this work progresses. |
thanks @denniskigen |
Requirements
Summary
This PR implements the print feature. This feature will later be implemented in the esm core, however, for testing purposes, I have implemented it in the vitals package within the patient chart.
Screenshots