Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Update start visit and visit notes forms to the new tablet design #1245

Merged
merged 5 commits into from Jun 30, 2023

Conversation

Jexsie
Copy link
Contributor

@Jexsie Jexsie commented Jun 28, 2023

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

  • Updates the tablet view of the start visit and visit notes forms to match the new tablet look
  • Checkout the start visit and the visit note designs

Screencasts

Screencast from 2023-06-28 10-53-56.webm
Screencast from 2023-06-28 10-57-37.webm

Related Issue

Other

  • Ignore the font changes. Had issues with importmaps so fonts were not loaded.

Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM @Jexsie. I've left a few tiny stylistic suggestions.

@denniskigen
Copy link
Member

I don't see the accompanying design changes to the visit notes form either from the screencasts or from running your changes locally. Did I miss something, @Jexsie?

@Jexsie
Copy link
Contributor Author

Jexsie commented Jun 30, 2023

I don't see the accompanying design changes to the visit notes form either from the screencasts or from running your changes locally. Did I miss something, @Jexsie?

works fine on my side
Screencast from 2023-06-30 11-50-19.webm

@denniskigen
Copy link
Member

I don't see the accompanying design changes to the visit notes form either from the screencasts or from running your changes locally. Did I miss something, @Jexsie?

works fine on my side Screencast from 2023-06-30 11-50-19.webm

Seen it. Thanks.

Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Jexsie!

@denniskigen denniskigen merged commit 3c9e229 into openmrs:main Jun 30, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants