New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) Update start visit and visit notes forms to the new tablet design #1245
Conversation
packages/esm-patient-notes-app/src/notes/visit-notes-form.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/visit/visit-form/visit-form.component.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM @Jexsie. I've left a few tiny stylistic suggestions.
packages/esm-patient-chart-app/src/visit/visit-form/location-selection.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/visit/visit-form/visit-form.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/visit/visit-form/visit-form.component.tsx
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/visit/visit-form/visit-form.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-notes-app/src/notes/visit-notes-form.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-notes-app/src/notes/visit-notes-form.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-notes-app/src/notes/visit-notes-form.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/visit/visit-form/visit-form.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/visit/visit-form/visit-form.scss
Outdated
Show resolved
Hide resolved
packages/esm-patient-chart-app/src/visit/visit-form/visit-form.component.tsx
Outdated
Show resolved
Hide resolved
I don't see the accompanying design changes to the visit notes form either from the screencasts or from running your changes locally. Did I miss something, @Jexsie? |
works fine on my side |
Seen it. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Jexsie!
Requirements
Summary
Screencasts
Screencast from 2023-06-28 10-53-56.webm
Screencast from 2023-06-28 10-57-37.webm
Related Issue
Other