(feat) Migrating conditions form to use RHF and Zod #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumuchris256
changed the title
lumuchris256
commented
Jun 29, 2023
| : null | ||
| : null, | ||
| clinicalStatus: condition?.cells?.find((cell) => cell?.info?.header === 'clinicalStatus')?.value ?? 'Active', | ||
| search: condition?.cells?.find((cell) => cell?.info?.header === 'display')?.value, |
There was a problem hiding this comment.
initilizing RHF with default values
lumuchris256
commented
Jun 29, 2023
| search: z.string({ required_error: "A condition is required"}), | ||
| }); | ||
|
|
||
| export type ConditionFormData = z.infer<typeof conditionSchema>; |
There was a problem hiding this comment.
infering form data type from the zod schema
lumuchris256
commented
Jun 29, 2023
| if (isSubmitting) { | ||
| editing ? handleUpdate() : handleCreate(); | ||
| if (formState?.errors?.search) { | ||
| searchInputFocus(); |
There was a problem hiding this comment.
focuses on the conditon's search input if an invalid condition is entered
lumuchris256
commented
Jun 29, 2023
| if (isSubmitting) { | ||
| editing ? handleUpdate() : handleCreate(); | ||
| if (formState?.errors?.search) { | ||
| searchInputFocus(); |
There was a problem hiding this comment.
focuses on the conditon's search input if an invalid condition is entered
lumuchris256
commented
Jul 2, 2023
| </ButtonSet> | ||
| </div> | ||
| </Form> | ||
| <FormProvider {...methods}> |
There was a problem hiding this comment.
Passing down form contexts and methods
api
lumuchris256
commented
Jul 2, 2023
| }) => { | ||
| const { t } = useTranslation(); | ||
| const { conditions, mutate } = useConditions(patientUuid); | ||
| const editing = formContext === 'editing'; | ||
| const { control, watch, getValues, formState } = useFormContext<ConditionFormData>(); |
There was a problem hiding this comment.
using the formcontext and methods api
hadijahkyampeire
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
-migrated the conditions form to use RHF and Zod
Screenshots
www_screencapture_com_2023-6-29_09_10.mp4
current update
Related Issue
https://issues.openmrs.org/browse/O3-2139 current
needs merging first #1232
Other
cc @hadijahkyampeire @denniskigen