Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) Put Patient Flags feature behind a feature toggle #1283

Merged
merged 2 commits into from
Jul 26, 2023
Merged

(feat) Put Patient Flags feature behind a feature toggle #1283

merged 2 commits into from
Jul 26, 2023

Conversation

denniskigen
Copy link
Member

@denniskigen denniskigen commented Jul 19, 2023 •
edited

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

The Patient Flags feature is currently still a work in progress and isn't ready for production. It makes sense to put it behind a feature flag. This PR adds a feature flag called patientFlags and wraps the feature behind it.

Screenshots

patient-flags-feature-toggle.mp4

Related Issue

https://issues.openmrs.org/browse/O3-2279

Other

None

@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2023 •
edited

Size Change: +183 B (0%)

Total Size: 7.54 MB

ℹ️ View Unchanged
Filename Size Change
packages/esm-form-engine-app/dist/130.js 134 kB 0 B
packages/esm-form-engine-app/dist/161.js 2.34 kB 0 B
packages/esm-form-engine-app/dist/215.js 170 kB 0 B
packages/esm-form-engine-app/dist/319.js 255 B 0 B
packages/esm-form-engine-app/dist/380.js 10.1 kB 0 B
packages/esm-form-engine-app/dist/469.js 6.66 kB 0 B
packages/esm-form-engine-app/dist/47.js 2.46 kB 0 B
packages/esm-form-engine-app/dist/527.js 102 kB 0 B
packages/esm-form-engine-app/dist/566.js 97.4 kB 0 B
packages/esm-form-engine-app/dist/574.js 255 B 0 B
packages/esm-form-engine-app/dist/591.js 16.8 kB 0 B
packages/esm-form-engine-app/dist/610.js 6.72 kB 0 B
packages/esm-form-engine-app/dist/757.js 255 B 0 B
packages/esm-form-engine-app/dist/784.js 2.63 kB 0 B
packages/esm-form-engine-app/dist/788.js 254 B 0 B
packages/esm-form-engine-app/dist/807.js 254 B 0 B
packages/esm-form-engine-app/dist/833.js 255 B 0 B
packages/esm-form-engine-app/dist/842.js 646 B 0 B
packages/esm-form-engine-app/dist/879.js 2.88 kB 0 B
packages/esm-form-engine-app/dist/911.js 843 B 0 B
packages/esm-form-engine-app/dist/main.js 3.62 kB 0 B
packages/esm-form-engine-app/dist/openmrs-esm-form-engine-app.js 3.47 kB 0 B
packages/esm-form-entry-app/dist/382.8d5d13b05f488f74291d.js 5.69 kB 0 B
packages/esm-form-entry-app/dist/574.2c5b56f88997e5ad583b.js 125 B 0 B
packages/esm-form-entry-app/dist/720.68fcd850693076dc3403.js 40.2 kB 0 B
packages/esm-form-entry-app/dist/802.77c63f091c0808a163bd.js 13 kB 0 B
packages/esm-form-entry-app/dist/807.7940b086abb64d0cf25a.js 125 B 0 B
packages/esm-form-entry-app/dist/815.8c52d20af2e7941e9798.js 101 B 0 B
packages/esm-form-entry-app/dist/996.f07c772e88fe2eebcee6.js 407 kB 0 B
packages/esm-form-entry-app/dist/main.94a5d927049b0a0d1a95.js 408 kB 0 B
packages/esm-form-entry-app/dist/openmrs-esm-form-entry-app.js 3.64 kB 0 B
packages/esm-generic-patient-widgets-app/dist/130.js 134 kB 0 B
packages/esm-generic-patient-widgets-app/dist/131.js 9.74 kB 0 B
packages/esm-generic-patient-widgets-app/dist/15.js 143 kB 0 B
packages/esm-generic-patient-widgets-app/dist/319.js 248 B 0 B
packages/esm-generic-patient-widgets-app/dist/442.js 11.2 kB 0 B
packages/esm-generic-patient-widgets-app/dist/47.js 2.47 kB 0 B
packages/esm-generic-patient-widgets-app/dist/574.js 96.3 kB 0 B
packages/esm-generic-patient-widgets-app/dist/588.js 6.67 kB 0 B
packages/esm-generic-patient-widgets-app/dist/591.js 16.9 kB 0 B
packages/esm-generic-patient-widgets-app/dist/635.js 5.96 kB 0 B
packages/esm-generic-patient-widgets-app/dist/757.js 275 B 0 B
packages/esm-generic-patient-widgets-app/dist/784.js 2.64 kB 0 B
packages/esm-generic-patient-widgets-app/dist/788.js 247 B 0 B
packages/esm-generic-patient-widgets-app/dist/807.js 303 B 0 B
packages/esm-generic-patient-widgets-app/dist/828.js 251 B 0 B
packages/esm-generic-patient-widgets-app/dist/833.js 287 B 0 B
packages/esm-generic-patient-widgets-app/dist/842.js 1.1 kB 0 B
packages/esm-generic-patient-widgets-app/dist/main.js 3.65 kB 0 B
packages/esm-generic-patient-widgets-app/dist/openmrs-esm-generic-patient-widgets-app.js 3.44 kB 0 B
packages/esm-patient-allergies-app/dist/130.js 134 kB 0 B
packages/esm-patient-allergies-app/dist/173.js 1.3 kB 0 B
packages/esm-patient-allergies-app/dist/251.js 9.24 kB 0 B
packages/esm-patient-allergies-app/dist/319.js 708 B 0 B
packages/esm-patient-allergies-app/dist/442.js 11.2 kB 0 B
packages/esm-patient-allergies-app/dist/443.js 3.61 kB 0 B
packages/esm-patient-allergies-app/dist/451.js 6.01 kB 0 B
packages/esm-patient-allergies-app/dist/47.js 2.47 kB 0 B
packages/esm-patient-allergies-app/dist/574.js 708 B 0 B
packages/esm-patient-allergies-app/dist/588.js 6.67 kB 0 B
packages/esm-patient-allergies-app/dist/591.js 16.9 kB 0 B
packages/esm-patient-allergies-app/dist/660.js 7.15 kB 0 B
packages/esm-patient-allergies-app/dist/729.js 2.7 kB 0 B
packages/esm-patient-allergies-app/dist/757.js 853 B 0 B
packages/esm-patient-allergies-app/dist/784.js 2.64 kB 0 B
packages/esm-patient-allergies-app/dist/788.js 706 B 0 B
packages/esm-patient-allergies-app/dist/802.js 3.75 kB 0 B
packages/esm-patient-allergies-app/dist/807.js 1.08 kB 0 B
packages/esm-patient-allergies-app/dist/828.js 2.53 kB 0 B
packages/esm-patient-allergies-app/dist/833.js 886 B 0 B
packages/esm-patient-allergies-app/dist/952.js 98.2 kB 0 B
packages/esm-patient-allergies-app/dist/main.js 3.96 kB 0 B
packages/esm-patient-allergies-app/dist/openmrs-esm-patient-allergies-app.js 3.43 kB 0 B
packages/esm-patient-appointments-app/dist/112.js 3.21 kB 0 B
packages/esm-patient-appointments-app/dist/130.js 134 kB 0 B
packages/esm-patient-appointments-app/dist/229.js 7.22 kB 0 B
packages/esm-patient-appointments-app/dist/251.js 9.24 kB 0 B
packages/esm-patient-appointments-app/dist/314.js 3.35 kB 0 B
packages/esm-patient-appointments-app/dist/319.js 901 B 0 B
packages/esm-patient-appointments-app/dist/323.js 2.29 kB 0 B
packages/esm-patient-appointments-app/dist/358.js 226 B 0 B
packages/esm-patient-appointments-app/dist/442.js 11.2 kB 0 B
packages/esm-patient-appointments-app/dist/469.js 6.66 kB 0 B
packages/esm-patient-appointments-app/dist/47.js 2.47 kB 0 B
packages/esm-patient-appointments-app/dist/574.js 892 B 0 B
packages/esm-patient-appointments-app/dist/591.js 16.9 kB 0 B
packages/esm-patient-appointments-app/dist/605.js 7.55 kB 0 B
packages/esm-patient-appointments-app/dist/610.js 6.72 kB 0 B
packages/esm-patient-appointments-app/dist/757.js 1.02 kB 0 B
packages/esm-patient-appointments-app/dist/768.js 141 kB 0 B
packages/esm-patient-appointments-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-appointments-app/dist/787.js 1.1 kB 0 B
packages/esm-patient-appointments-app/dist/788.js 899 B 0 B
packages/esm-patient-appointments-app/dist/807.js 1.21 kB 0 B
packages/esm-patient-appointments-app/dist/833.js 1.04 kB 0 B
packages/esm-patient-appointments-app/dist/879.js 2.89 kB 0 B
packages/esm-patient-appointments-app/dist/907.js 4.68 kB 0 B
packages/esm-patient-appointments-app/dist/916.js 226 B 0 B
packages/esm-patient-appointments-app/dist/main.js 4 kB 0 B
packages/esm-patient-appointments-app/dist/openmrs-esm-patient-appointments-app.js 3.48 kB 0 B
packages/esm-patient-attachments-app/dist/106.js 7.01 kB 0 B
packages/esm-patient-attachments-app/dist/130.js 134 kB 0 B
packages/esm-patient-attachments-app/dist/202.js 2.86 kB 0 B
packages/esm-patient-attachments-app/dist/251.js 9.24 kB 0 B
packages/esm-patient-attachments-app/dist/319.js 774 B 0 B
packages/esm-patient-attachments-app/dist/425.js 93.3 kB 0 B
packages/esm-patient-attachments-app/dist/442.js 11.2 kB 0 B
packages/esm-patient-attachments-app/dist/47.js 2.47 kB 0 B
packages/esm-patient-attachments-app/dist/50.js 595 B 0 B
packages/esm-patient-attachments-app/dist/525.js 802 B 0 B
packages/esm-patient-attachments-app/dist/533.js 7.4 kB 0 B
packages/esm-patient-attachments-app/dist/574.js 773 B 0 B
packages/esm-patient-attachments-app/dist/588.js 6.67 kB 0 B
packages/esm-patient-attachments-app/dist/591.js 16.9 kB 0 B
packages/esm-patient-attachments-app/dist/593.js 5.82 kB 0 B
packages/esm-patient-attachments-app/dist/621.js 1.1 kB 0 B
packages/esm-patient-attachments-app/dist/672.js 15.3 kB 0 B
packages/esm-patient-attachments-app/dist/757.js 899 B 0 B
packages/esm-patient-attachments-app/dist/767.js 1.17 kB 0 B
packages/esm-patient-attachments-app/dist/784.js 2.64 kB 0 B
packages/esm-patient-attachments-app/dist/788.js 771 B 0 B
packages/esm-patient-attachments-app/dist/807.js 1.1 kB 0 B
packages/esm-patient-attachments-app/dist/833.js 898 B 0 B
packages/esm-patient-attachments-app/dist/95.js 5.86 kB 0 B
packages/esm-patient-attachments-app/dist/main.js 4 kB 0 B
packages/esm-patient-attachments-app/dist/openmrs-esm-patient-attachments-app.js 3.43 kB 0 B
packages/esm-patient-banner-app/dist/130.js 134 kB 0 B
packages/esm-patient-banner-app/dist/147.js 1.13 kB 0 B
packages/esm-patient-banner-app/dist/238.js 18.2 kB 0 B
packages/esm-patient-banner-app/dist/251.js 9.23 kB 0 B
packages/esm-patient-banner-app/dist/303.js 4.46 kB 0 B
packages/esm-patient-banner-app/dist/319.js 493 B 0 B
packages/esm-patient-banner-app/dist/43.js 394 B 0 B
packages/esm-patient-banner-app/dist/442.js 11.2 kB 0 B
packages/esm-patient-banner-app/dist/47.js 2.47 kB 0 B
packages/esm-patient-banner-app/dist/472.js 912 B 0 B
packages/esm-patient-banner-app/dist/53.js 7.37 kB 0 B
packages/esm-patient-banner-app/dist/574.js 497 B 0 B
packages/esm-patient-banner-app/dist/588.js 6.67 kB 0 B
packages/esm-patient-banner-app/dist/591.js 16.8 kB 0 B
packages/esm-patient-banner-app/dist/757.js 541 B 0 B
packages/esm-patient-banner-app/dist/779.js 5.77 kB 0 B
packages/esm-patient-banner-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-banner-app/dist/788.js 492 B 0 B
packages/esm-patient-banner-app/dist/807.js 645 B 0 B
packages/esm-patient-banner-app/dist/833.js 594 B 0 B
packages/esm-patient-banner-app/dist/842.js 957 B 0 B
packages/esm-patient-banner-app/dist/main.js 3.64 kB 0 B
packages/esm-patient-banner-app/dist/openmrs-esm-patient-banner-app.js 3.45 kB 0 B
packages/esm-patient-biometrics-app/dist/107.js 342 B 0 B
packages/esm-patient-biometrics-app/dist/130.js 134 kB 0 B
packages/esm-patient-biometrics-app/dist/131.js 9.74 kB 0 B
packages/esm-patient-biometrics-app/dist/15.js 142 kB 0 B
packages/esm-patient-biometrics-app/dist/208.js 91.6 kB 0 B
packages/esm-patient-biometrics-app/dist/212.js 1.44 kB 0 B
packages/esm-patient-biometrics-app/dist/319.js 308 B 0 B
packages/esm-patient-biometrics-app/dist/442.js 11.2 kB 0 B
packages/esm-patient-biometrics-app/dist/465.js 5.79 kB 0 B
packages/esm-patient-biometrics-app/dist/47.js 2.47 kB 0 B
packages/esm-patient-biometrics-app/dist/574.js 308 B 0 B
packages/esm-patient-biometrics-app/dist/588.js 6.67 kB 0 B
packages/esm-patient-biometrics-app/dist/591.js 16.9 kB 0 B
packages/esm-patient-biometrics-app/dist/757.js 322 B 0 B
packages/esm-patient-biometrics-app/dist/758.js 341 B 0 B
packages/esm-patient-biometrics-app/dist/784.js 2.64 kB 0 B
packages/esm-patient-biometrics-app/dist/788.js 307 B 0 B
packages/esm-patient-biometrics-app/dist/807.js 308 B 0 B
packages/esm-patient-biometrics-app/dist/833.js 370 B 0 B
packages/esm-patient-biometrics-app/dist/878.js 2.55 kB 0 B
packages/esm-patient-biometrics-app/dist/93.js 5.99 kB 0 B
packages/esm-patient-biometrics-app/dist/main.js 3.97 kB 0 B
packages/esm-patient-biometrics-app/dist/openmrs-esm-patient-biometrics-app.js 3.42 kB 0 B
packages/esm-patient-chart-app/dist/130.js 134 kB 0 B
packages/esm-patient-chart-app/dist/1522.js 541 B 0 B
packages/esm-patient-chart-app/dist/1730.js 4.55 kB 0 B
packages/esm-patient-chart-app/dist/2757.js 2.47 kB 0 B
packages/esm-patient-chart-app/dist/2784.js 2.63 kB 0 B
packages/esm-patient-chart-app/dist/2990.js 1.3 kB 0 B
packages/esm-patient-chart-app/dist/309.js 6.45 kB 0 B
packages/esm-patient-chart-app/dist/3255.js 4.41 kB 0 B
packages/esm-patient-chart-app/dist/338.js 2.38 kB 0 B
packages/esm-patient-chart-app/dist/3574.js 2.06 kB 0 B
packages/esm-patient-chart-app/dist/3753.js 3.37 kB 0 B
packages/esm-patient-chart-app/dist/4202.js 1.34 kB 0 B
packages/esm-patient-chart-app/dist/4379.js 3.73 kB 0 B
packages/esm-patient-chart-app/dist/443.js 1.14 kB 0 B
packages/esm-patient-chart-app/dist/4583.js 3.3 kB 0 B
packages/esm-patient-chart-app/dist/4713.js 4.68 kB 0 B
packages/esm-patient-chart-app/dist/4714.js 9.44 kB 0 B
packages/esm-patient-chart-app/dist/4843.js 3.6 kB 0 B
packages/esm-patient-chart-app/dist/5047.js 2.47 kB 0 B
packages/esm-patient-chart-app/dist/5137.js 3.86 kB 0 B
packages/esm-patient-chart-app/dist/5169.js 1.14 kB 0 B
packages/esm-patient-chart-app/dist/5251.js 9.22 kB 0 B
packages/esm-patient-chart-app/dist/5485.js 481 B 0 B
packages/esm-patient-chart-app/dist/5634.js 9.31 kB 0 B
packages/esm-patient-chart-app/dist/5833.js 2.44 kB 0 B
packages/esm-patient-chart-app/dist/6002.js 450 B 0 B
packages/esm-patient-chart-app/dist/610.js 6.71 kB 0 B
packages/esm-patient-chart-app/dist/6150.js 12.4 kB 0 B
packages/esm-patient-chart-app/dist/6373.js 11.9 kB 0 B
packages/esm-patient-chart-app/dist/6579.js 428 B 0 B
packages/esm-patient-chart-app/dist/6591.js 16.8 kB 0 B
packages/esm-patient-chart-app/dist/6630.js 2.31 kB 0 B
packages/esm-patient-chart-app/dist/6642.js 4.34 kB 0 B
packages/esm-patient-chart-app/dist/6721.js 4.23 kB 0 B
packages/esm-patient-chart-app/dist/686.js 564 B 0 B
packages/esm-patient-chart-app/dist/6913.js 3.15 kB 0 B
packages/esm-patient-chart-app/dist/7046.js 4.85 kB 0 B
packages/esm-patient-chart-app/dist/7244.js 474 B 0 B
packages/esm-patient-chart-app/dist/7631.js 2.26 kB 0 B
packages/esm-patient-chart-app/dist/766.js 183 kB 0 B
packages/esm-patient-chart-app/dist/7807.js 3.12 kB 0 B
packages/esm-patient-chart-app/dist/781.js 2.33 kB 0 B
packages/esm-patient-chart-app/dist/8319.js 2.05 kB 0 B
packages/esm-patient-chart-app/dist/8512.js 3.35 kB 0 B
packages/esm-patient-chart-app/dist/8788.js 2.05 kB 0 B
packages/esm-patient-chart-app/dist/8879.js 2.89 kB 0 B
packages/esm-patient-chart-app/dist/9331.js 2.47 kB 0 B
packages/esm-patient-chart-app/dist/9469.js 476 B 0 B
packages/esm-patient-chart-app/dist/948.js 2.85 kB -3 B (0%)
packages/esm-patient-chart-app/dist/9692.js 3.37 kB 0 B
packages/esm-patient-chart-app/dist/main.js 7.52 kB 0 B
packages/esm-patient-chart-app/dist/openmrs-esm-patient-chart-app.js 3.67 kB 0 B
packages/esm-patient-conditions-app/dist/130.js 134 kB 0 B
packages/esm-patient-conditions-app/dist/173.js 1.23 kB 0 B
packages/esm-patient-conditions-app/dist/248.js 129 kB 0 B
packages/esm-patient-conditions-app/dist/251.js 9.23 kB 0 B
packages/esm-patient-conditions-app/dist/319.js 610 B 0 B
packages/esm-patient-conditions-app/dist/320.js 7.25 kB 0 B
packages/esm-patient-conditions-app/dist/435.js 3.61 kB 0 B
packages/esm-patient-conditions-app/dist/442.js 11.2 kB 0 B
packages/esm-patient-conditions-app/dist/452.js 3.65 kB 0 B
packages/esm-patient-conditions-app/dist/469.js 6.66 kB 0 B
packages/esm-patient-conditions-app/dist/47.js 2.47 kB 0 B
packages/esm-patient-conditions-app/dist/526.js 2.53 kB 0 B
packages/esm-patient-conditions-app/dist/574.js 610 B 0 B
packages/esm-patient-conditions-app/dist/587.js 3.61 kB 0 B
packages/esm-patient-conditions-app/dist/591.js 16.9 kB 0 B
packages/esm-patient-conditions-app/dist/610.js 6.72 kB 0 B
packages/esm-patient-conditions-app/dist/689.js 10.3 kB 0 B
packages/esm-patient-conditions-app/dist/757.js 691 B 0 B
packages/esm-patient-conditions-app/dist/784.js 2.64 kB 0 B
packages/esm-patient-conditions-app/dist/788.js 607 B 0 B
packages/esm-patient-conditions-app/dist/807.js 845 B 0 B
packages/esm-patient-conditions-app/dist/833.js 729 B 0 B
packages/esm-patient-conditions-app/dist/845.js 5.19 kB 0 B
packages/esm-patient-conditions-app/dist/879.js 2.89 kB 0 B
packages/esm-patient-conditions-app/dist/940.js 13.2 kB 0 B
packages/esm-patient-conditions-app/dist/941.js 6.02 kB 0 B
packages/esm-patient-conditions-app/dist/main.js 4.02 kB 0 B
packages/esm-patient-conditions-app/dist/openmrs-esm-patient-conditions-app.js 3.48 kB 0 B
packages/esm-patient-flags-app/dist/130.js 134 kB 0 B
packages/esm-patient-flags-app/dist/251.js 9.23 kB 0 B
packages/esm-patient-flags-app/dist/319.js 506 B 0 B
packages/esm-patient-flags-app/dist/418.js 2.91 kB 0 B
packages/esm-patient-flags-app/dist/442.js 11.2 kB 0 B
packages/esm-patient-flags-app/dist/47.js 2.47 kB 0 B
packages/esm-patient-flags-app/dist/492.js 4.99 kB 0 B
packages/esm-patient-flags-app/dist/518.js 3.68 kB 0 B
packages/esm-patient-flags-app/dist/574.js 496 B 0 B
packages/esm-patient-flags-app/dist/591.js 16.8 kB 0 B
packages/esm-patient-flags-app/dist/610.js 6.72 kB 0 B
packages/esm-patient-flags-app/dist/660.js 5.49 kB 0 B
packages/esm-patient-flags-app/dist/757.js 506 B 0 B
packages/esm-patient-flags-app/dist/783.js 3.96 kB 0 B
packages/esm-patient-flags-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-flags-app/dist/788.js 494 B 0 B
packages/esm-patient-flags-app/dist/789.js 6.42 kB 0 B
packages/esm-patient-flags-app/dist/807.js 481 B 0 B
packages/esm-patient-flags-app/dist/833.js 505 B 0 B
packages/esm-patient-flags-app/dist/842.js 853 B +186 B (+28%) 🚨
packages/esm-patient-flags-app/dist/935.js 22.8 kB 0 B
packages/esm-patient-flags-app/dist/965.js 14.3 kB 0 B
packages/esm-patient-flags-app/dist/main.js 3.65 kB 0 B
packages/esm-patient-flags-app/dist/openmrs-esm-patient-flags-app.js 3.44 kB 0 B
packages/esm-patient-forms-app/dist/130.js 134 kB 0 B
packages/esm-patient-forms-app/dist/2.js 4.87 kB 0 B
packages/esm-patient-forms-app/dist/217.js 2.11 kB 0 B
packages/esm-patient-forms-app/dist/23.js 1.95 kB 0 B
packages/esm-patient-forms-app/dist/251.js 9.22 kB 0 B
packages/esm-patient-forms-app/dist/255.js 4.4 kB 0 B
packages/esm-patient-forms-app/dist/319.js 606 B 0 B
packages/esm-patient-forms-app/dist/338.js 4.83 kB 0 B
packages/esm-patient-forms-app/dist/34.js 85 kB 0 B
packages/esm-patient-forms-app/dist/383.js 1.9 kB 0 B
packages/esm-patient-forms-app/dist/442.js 11.2 kB 0 B
packages/esm-patient-forms-app/dist/47.js 2.47 kB 0 B
packages/esm-patient-forms-app/dist/513.js 1.29 kB 0 B
packages/esm-patient-forms-app/dist/525.js 501 B 0 B
packages/esm-patient-forms-app/dist/56.js 9.02 kB 0 B
packages/esm-patient-forms-app/dist/573.js 3.8 kB 0 B
packages/esm-patient-forms-app/dist/574.js 614 B 0 B
packages/esm-patient-forms-app/dist/588.js 6.67 kB 0 B
packages/esm-patient-forms-app/dist/591.js 16.8 kB 0 B
packages/esm-patient-forms-app/dist/713.js 4.72 kB 0 B
packages/esm-patient-forms-app/dist/725.js 2.98 kB 0 B
packages/esm-patient-forms-app/dist/757.js 748 B 0 B
packages/esm-patient-forms-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-forms-app/dist/788.js 604 B 0 B
packages/esm-patient-forms-app/dist/807.js 907 B 0 B
packages/esm-patient-forms-app/dist/833.js 764 B 0 B
packages/esm-patient-forms-app/dist/879.js 2.88 kB 0 B
packages/esm-patient-forms-app/dist/main.js 8.65 kB 0 B
packages/esm-patient-forms-app/dist/openmrs-esm-patient-forms-app.js 3.51 kB 0 B
packages/esm-patient-immunizations-app/dist/130.js 134 kB 0 B
packages/esm-patient-immunizations-app/dist/187.js 3.61 kB 0 B
packages/esm-patient-immunizations-app/dist/230.js 10.1 kB 0 B
packages/esm-patient-immunizations-app/dist/233.js 1.46 kB 0 B
packages/esm-patient-immunizations-app/dist/278.js 1.77 kB 0 B
packages/esm-patient-immunizations-app/dist/28.js 3.72 kB 0 B
packages/esm-patient-immunizations-app/dist/319.js 430 B 0 B
packages/esm-patient-immunizations-app/dist/340.js 127 kB 0 B
packages/esm-patient-immunizations-app/dist/442.js 11.2 kB 0 B
packages/esm-patient-immunizations-app/dist/47.js 2.47 kB 0 B
packages/esm-patient-immunizations-app/dist/574.js 430 B 0 B
packages/esm-patient-immunizations-app/dist/588.js 6.67 kB 0 B
packages/esm-patient-immunizations-app/dist/591.js 16.9 kB 0 B
packages/esm-patient-immunizations-app/dist/757.js 441 B 0 B
packages/esm-patient-immunizations-app/dist/784.js 2.64 kB 0 B
packages/esm-patient-immunizations-app/dist/788.js 428 B 0 B
packages/esm-patient-immunizations-app/dist/807.js 489 B 0 B
packages/esm-patient-immunizations-app/dist/833.js 522 B 0 B
packages/esm-patient-immunizations-app/dist/903.js 4.09 kB 0 B
packages/esm-patient-immunizations-app/dist/main.js 3.95 kB 0 B
packages/esm-patient-immunizations-app/dist/openmrs-esm-patient-immunizations-app.js 3.43 kB 0 B
packages/esm-patient-medications-app/dist/130.js 134 kB 0 B
packages/esm-patient-medications-app/dist/173.js 1.5 kB 0 B
packages/esm-patient-medications-app/dist/251.js 9.23 kB 0 B
packages/esm-patient-medications-app/dist/263.js 6.72 kB 0 B
packages/esm-patient-medications-app/dist/319.js 1.55 kB 0 B
packages/esm-patient-medications-app/dist/350.js 5.94 kB 0 B
packages/esm-patient-medications-app/dist/415.js 2.23 kB 0 B
packages/esm-patient-medications-app/dist/442.js 11.2 kB 0 B
packages/esm-patient-medications-app/dist/469.js 6.66 kB 0 B
packages/esm-patient-medications-app/dist/47.js 2.47 kB 0 B
packages/esm-patient-medications-app/dist/574.js 1.51 kB 0 B
packages/esm-patient-medications-app/dist/591.js 16.9 kB 0 B
packages/esm-patient-medications-app/dist/592.js 4.27 kB 0 B
packages/esm-patient-medications-app/dist/610.js 6.72 kB 0 B
packages/esm-patient-medications-app/dist/695.js 565 B 0 B
packages/esm-patient-medications-app/dist/757.js 1.55 kB 0 B
packages/esm-patient-medications-app/dist/784.js 2.64 kB 0 B
packages/esm-patient-medications-app/dist/788.js 1.51 kB 0 B
packages/esm-patient-medications-app/dist/807.js 2.07 kB 0 B
packages/esm-patient-medications-app/dist/833.js 1.77 kB 0 B
packages/esm-patient-medications-app/dist/879.js 2.89 kB 0 B
packages/esm-patient-medications-app/dist/882.js 140 kB 0 B
packages/esm-patient-medications-app/dist/972.js 1.33 kB 0 B
packages/esm-patient-medications-app/dist/974.js 19.4 kB 0 B
packages/esm-patient-medications-app/dist/main.js 4.01 kB 0 B
packages/esm-patient-medications-app/dist/openmrs-esm-patient-medications-app.js 3.47 kB 0 B
packages/esm-patient-notes-app/dist/130.js 134 kB 0 B
packages/esm-patient-notes-app/dist/188.js 2.42 kB 0 B
packages/esm-patient-notes-app/dist/258.js 1.81 kB 0 B
packages/esm-patient-notes-app/dist/271.js 21.5 kB 0 B
packages/esm-patient-notes-app/dist/292.js 2.63 kB 0 B
packages/esm-patient-notes-app/dist/310.js 5.22 kB 0 B
packages/esm-patient-notes-app/dist/319.js 675 B 0 B
packages/esm-patient-notes-app/dist/417.js 9.83 kB 0 B
packages/esm-patient-notes-app/dist/45.js 4.75 kB 0 B
packages/esm-patient-notes-app/dist/47.js 2.46 kB 0 B
packages/esm-patient-notes-app/dist/574.js 673 B 0 B
packages/esm-patient-notes-app/dist/587.js 117 kB 0 B
packages/esm-patient-notes-app/dist/588.js 6.67 kB 0 B
packages/esm-patient-notes-app/dist/591.js 16.8 kB 0 B
packages/esm-patient-notes-app/dist/667.js 341 B 0 B
packages/esm-patient-notes-app/dist/709.js 4.8 kB 0 B
packages/esm-patient-notes-app/dist/743.js 6.39 kB 0 B
packages/esm-patient-notes-app/dist/757.js 805 B 0 B
packages/esm-patient-notes-app/dist/784.js 10.1 kB 0 B
packages/esm-patient-notes-app/dist/788.js 673 B 0 B
packages/esm-patient-notes-app/dist/807.js 993 B 0 B
packages/esm-patient-notes-app/dist/833.js 791 B 0 B
packages/esm-patient-notes-app/dist/838.js 334 B 0 B
packages/esm-patient-notes-app/dist/879.js 2.89 kB 0 B
packages/esm-patient-notes-app/dist/963.js 952 B 0 B
packages/esm-patient-notes-app/dist/main.js 3.71 kB 0 B
packages/esm-patient-notes-app/dist/openmrs-esm-patient-notes-app.js 3.5 kB 0 B
packages/esm-patient-programs-app/dist/130.js 134 kB 0 B
packages/esm-patient-programs-app/dist/173.js 1.07 kB 0 B
packages/esm-patient-programs-app/dist/295.js 126 kB 0 B
packages/esm-patient-programs-app/dist/319.js 628 B 0 B
packages/esm-patient-programs-app/dist/411.js 4.91 kB 0 B
packages/esm-patient-programs-app/dist/442.js 11.2 kB 0 B
packages/esm-patient-programs-app/dist/47.js 2.47 kB 0 B
packages/esm-patient-programs-app/dist/534.js 1.8 kB 0 B
packages/esm-patient-programs-app/dist/574.js 628 B 0 B
packages/esm-patient-programs-app/dist/582.js 9.73 kB 0 B
packages/esm-patient-programs-app/dist/588.js 6.67 kB 0 B
packages/esm-patient-programs-app/dist/591.js 16.9 kB 0 B
packages/esm-patient-programs-app/dist/757.js 739 B 0 B
packages/esm-patient-programs-app/dist/784.js 2.64 kB 0 B
packages/esm-patient-programs-app/dist/788.js 627 B 0 B
packages/esm-patient-programs-app/dist/807.js 929 B 0 B
packages/esm-patient-programs-app/dist/808.js 3.51 kB 0 B
packages/esm-patient-programs-app/dist/833.js 763 B 0 B
packages/esm-patient-programs-app/dist/879.js 2.89 kB 0 B
packages/esm-patient-programs-app/dist/942.js 3.99 kB 0 B
packages/esm-patient-programs-app/dist/main.js 3.97 kB 0 B
packages/esm-patient-programs-app/dist/openmrs-esm-patient-programs-app.js 3.47 kB 0 B
packages/esm-patient-test-results-app/dist/127.js 91.1 kB 0 B
packages/esm-patient-test-results-app/dist/130.js 134 kB 0 B
packages/esm-patient-test-results-app/dist/131.js 9.74 kB 0 B
packages/esm-patient-test-results-app/dist/242.js 5.14 kB 0 B
packages/esm-patient-test-results-app/dist/319.js 547 B 0 B
packages/esm-patient-test-results-app/dist/442.js 11.2 kB 0 B
packages/esm-patient-test-results-app/dist/47.js 2.47 kB 0 B
packages/esm-patient-test-results-app/dist/567.js 48.5 kB 0 B
packages/esm-patient-test-results-app/dist/574.js 547 B 0 B
packages/esm-patient-test-results-app/dist/588.js 6.67 kB 0 B
packages/esm-patient-test-results-app/dist/591.js 16.9 kB 0 B
packages/esm-patient-test-results-app/dist/757.js 625 B 0 B
packages/esm-patient-test-results-app/dist/784.js 2.64 kB 0 B
packages/esm-patient-test-results-app/dist/788.js 546 B 0 B
packages/esm-patient-test-results-app/dist/807.js 757 B 0 B
packages/esm-patient-test-results-app/dist/833.js 665 B 0 B
packages/esm-patient-test-results-app/dist/842.js 1.32 kB 0 B
packages/esm-patient-test-results-app/dist/851.js 190 kB 0 B
packages/esm-patient-test-results-app/dist/890.js 8.58 kB 0 B
packages/esm-patient-test-results-app/dist/896.js 833 B 0 B
packages/esm-patient-test-results-app/dist/93.js 4.29 kB 0 B
packages/esm-patient-test-results-app/dist/main.js 4 kB 0 B
packages/esm-patient-test-results-app/dist/openmrs-esm-patient-test-results-app.js 3.44 kB 0 B
packages/esm-patient-vitals-app/dist/130.js 134 kB 0 B
packages/esm-patient-vitals-app/dist/131.js 9.73 kB 0 B
packages/esm-patient-vitals-app/dist/313.js 8.78 kB 0 B
packages/esm-patient-vitals-app/dist/319.js 780 B 0 B
packages/esm-patient-vitals-app/dist/442.js 11.2 kB 0 B
packages/esm-patient-vitals-app/dist/47.js 2.47 kB 0 B
packages/esm-patient-vitals-app/dist/49.js 151 kB 0 B
packages/esm-patient-vitals-app/dist/532.js 668 B 0 B
packages/esm-patient-vitals-app/dist/560.js 11.4 kB 0 B
packages/esm-patient-vitals-app/dist/574.js 778 B 0 B
packages/esm-patient-vitals-app/dist/588.js 6.67 kB 0 B
packages/esm-patient-vitals-app/dist/591.js 16.8 kB 0 B
packages/esm-patient-vitals-app/dist/630.js 336 B 0 B
packages/esm-patient-vitals-app/dist/638.js 342 B 0 B
packages/esm-patient-vitals-app/dist/750.js 98.2 kB 0 B
packages/esm-patient-vitals-app/dist/757.js 945 B 0 B
packages/esm-patient-vitals-app/dist/784.js 2.63 kB 0 B
packages/esm-patient-vitals-app/dist/788.js 779 B 0 B
packages/esm-patient-vitals-app/dist/807.js 1.11 kB 0 B
packages/esm-patient-vitals-app/dist/812.js 1.34 kB 0 B
packages/esm-patient-vitals-app/dist/833.js 927 B 0 B
packages/esm-patient-vitals-app/dist/879.js 2.88 kB 0 B
packages/esm-patient-vitals-app/dist/93.js 5.99 kB 0 B
packages/esm-patient-vitals-app/dist/981.js 4.99 kB 0 B
packages/esm-patient-vitals-app/dist/main.js 3.71 kB 0 B
packages/esm-patient-vitals-app/dist/openmrs-esm-patient-vitals-app.js 3.48 kB 0 B

compressed-size-action

hadijahkyampeire
hadijahkyampeire approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@hadijahkyampeire hadijahkyampeire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @denniskigen LGTM

brandones
brandones reviewed Jul 21, 2023
View reviewed changes
packages/esm-patient-flags-app/src/index.ts
registerFeatureFlag(
'patientFlags',
'Patient Flags',
'Visual components that enable healthcare providers to see relevant patient information with a glance in the Patient chart. Flags are displayed in the Patient Summary, just below the patient banner, and can link users to other areas of the chart to perform relevant actions during a visit.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful description, thank you 👏

@brandones
Copy link
Contributor

Why are we making changes within FlagsHighlightBar, FlagsList, and Flags? Why not just keep those components out of the tree in the first place and call that good?

@denniskigen
Copy link
Member Author

denniskigen commented Jul 21, 2023 •
edited

No need to call useFeatureFlag at any point? @brandones. Maybe I'm missing something in my local setup?

@brandones
Copy link
Contributor

No need to call useFeatureFlag at any point?

Yeah, right? Like we just prevent the extension from mounting at all and we're good.

Maybe I'm missing something in my local setup?

What? Oh, do you mean that only modifying the extension definition doesn't change it locally for you? Is it because you need to coerce your dev server into reloading the routes somehow?

@denniskigen
Copy link
Member Author

denniskigen commented Jul 26, 2023 •
edited

What? Oh, do you mean that only modifying the extension definition doesn't change it locally for you? Is it because you need to coerce your dev server into reloading the routes somehow?

That's it! I've just checked the routes registry file and noticed that the featureFlag property isn't getting picked up regardless of how many times I reload. For context, I'm running a dev server off esm-core (via yarn run:shell) and then adding an import map override for the flags app (via the import map overrides panel). The approach seems sound despite the fact I can't test locally. So I've updated the PR to remove the use of the useFeatureFlag hook. Rendering the extensions is now dependent on the featureFlag property in the routes registry.

brandones
brandones approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@brandones brandones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dennis. I'm good approving this as is, but heads up to @ibacher about the difficulties with the dev server and routes—I think this challenge is an already familiar one but just want to make sure.

@ibacher
Copy link
Member

ibacher commented Jul 26, 2023

Yeah, this is a known issue. If you run yarn start (so openmrs develop) rather than run:shell, we override the resulting routes.registry.json to include the local module. If you run things with run:shell, though, we have no way of knowing about the new routes to add—we'd have to add tooling similar to the importmap overrides to allow you to define route overrides. (If there are better ways to handle this, I'm open to it!).

@denniskigen
Copy link
Member Author

Thanks for the suggestions and the reviews!

@denniskigen denniskigen merged commit 1f8854d into main Jul 26, 2023
5 checks passed
@denniskigen denniskigen deleted the feat/flags-feature-toggle branch July 26, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandones brandones brandones approved these changes

@hadijahkyampeire hadijahkyampeire hadijahkyampeire approved these changes

@dkayiwa dkayiwa Awaiting requested review from dkayiwa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@denniskigen @brandones @ibacher @hadijahkyampeire