(fix) resolves valid route with grouped chart dashboards #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +7 B (0%) Total Size: 7.52 MB ℹ️ View Unchanged
|
samuelmale
reviewed
Jul 24, 2023
Comment on lines
49
to
51
| const filteredDashboards = dashboards.filter((dashboard) => { | ||
| if ('path' in dashboard) return dashboard; | ||
| }); |
There was a problem hiding this comment.
Suggested change
| const filteredDashboards = dashboards.filter((dashboard) => { | |
| if ('path' in dashboard) return dashboard; | |
| }); | |
| const filteredDashboards = dashboards.filter(dashboard => 'path' in dashboard); | |
Question: @pirupius Shouldn't our filter only give a pass for dashboards with a valid path? Like a truthy one?
const filteredDashboards = dashboards.filter(dashboard => dashboard.path);I think we should also log to console all excluded dashboards and flag them as missing a path property
There was a problem hiding this comment.
The dashboards without paths are mostly flags and other components that necessarily don't appear in the sidenav so there's no need to add a console log
samuelmale
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
When the patient chart has only folders, the combined array of ungrouped and grouped dashboards has an empty path on index 0 which doesn't resolve. This PR adds a filter to remove dashboards without the
pathkey to ensure the index 0 is validScreenshots
Related Issue
Other