-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) O3-2196: Implement the print functionality for Test results #1306
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Please make the requested changes and we'll get it in.
packages/esm-patient-test-results-app/src/print/print.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-test-results-app/src/print/print.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-test-results-app/src/print/print.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-test-results-app/src/print/print.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-test-results-app/src/print/print.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-test-results-app/src/print/print.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-test-results-app/src/print/print.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-test-results-app/src/print/print.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-test-results-app/src/print/print.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-test-results-app/src/print/print.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-test-results-app/src/print/print.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-test-results-app/src/print/print.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-test-results-app/src/print/print.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-test-results-app/src/print/print.component.tsx
Outdated
Show resolved
Hide resolved
}, | ||
{ | ||
"name": "print", | ||
"component": "print" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which slot does this extension get rendered into?
Thanks, @nanfuka. The Tablet also looks good |
packages/esm-patient-test-results-app/src/print-modal/print-modal.component.tsx
Show resolved
Hide resolved
packages/esm-patient-test-results-app/src/print-modal/print-modal.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-test-results-app/src/print-modal/print-modal.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-test-results-app/src/print-modal/print-modal.component.tsx
Outdated
Show resolved
Hide resolved
Please provide an updated video once it looks right. |
const displayText = t('testReasults', 'Test results'); | ||
const headerTitle = t('testReasults', 'Test results'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const displayText = t('testReasults', 'Test results'); | |
const headerTitle = t('testReasults', 'Test results'); | |
const displayText = t('testResults', 'Test results'); | |
const headerTitle = t('testResults', 'Test results'); |
Am yet to convert the date picker into the date range picker as suggested by the design team. |
Please @ me when ready for re-review, or hit the "request re-review" button if it is available to you |
@brandones @denniskigen @hadijahkyampeire I've made the requested changes. Could you please re-review? Thank you! |
packages/esm-patient-test-results-app/src/print-modal/print-modal.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-test-results-app/src/print-modal/print-modal.component.tsx
Outdated
Show resolved
Hide resolved
packages/esm-patient-test-results-app/src/print-modal/print-modal.component.tsx
Outdated
Show resolved
Hide resolved
Ok, just a few more suggestions. |
"Test Results": "Test Results", | ||
"testName": "Test name", | ||
"testReasults": "Test results", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"testReasults": "Test results", |
When fixing typos, please use ctrl-shift-F global search to clean up. A global search of "testReasults" would have found this.
there is a CI build failure though. there is a failing test in esm common lib. |
I rebased your branch on main and pushed. That fixed the problem. Your branch was not up to date. You should keep your branches for your PRs up to date. |
Requirements
Summary
In case the "Show Print Button" is enabled in the configurations, the print button becomes visible within the header of the test results section. Upon clicking this print button, a popup emerges, housing a data table that showcases the patient's test results. This popup incorporates another print button. Activating this button initiates the printing process.
Screenshots
The location of the print button
The print modal when there are no test results for the selected period
Appearance of print modal before any selections are made
When a range of dates is selected
Related Issue
None
Other
None