(enhc) Remove un-used forms code and updated forms config. #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -119 B (0%) Total Size: 8.38 MB ℹ️ View Unchanged
|
denniskigen
reviewed
Sep 12, 2023
| @@ -13,8 +13,9 @@ import { ConfigObject } from '../config-schema'; | |||
| import { isValidOfflineFormEncounter } from '../offline-forms/offline-form-helpers'; | |||
|
|
|||
| export function useFormEncounters(cachedOfflineFormsOnly = false, patientUuid: string = '') { | |||
| const { showConfigurableForms, customFormsUrl, showHtmlFormEntryForms } = useConfig() as ConfigObject; | |||
| const url = showConfigurableForms | |||
| const { customFormsUrl, showHtmlFormEntryForms } = useConfig() as ConfigObject; | |||
There was a problem hiding this comment.
Suggested change
| const { customFormsUrl, showHtmlFormEntryForms } = useConfig() as ConfigObject; | |
| const { customFormsUrl, showHtmlFormEntryForms } = useConfig<ConfigObject>(); |
denniskigen
reviewed
Sep 12, 2023
| const { showConfigurableForms, customFormsUrl, showHtmlFormEntryForms } = useConfig() as ConfigObject; | ||
| const url = showConfigurableForms | ||
| const { customFormsUrl, showHtmlFormEntryForms } = useConfig() as ConfigObject; | ||
| const isCustomUrl = Boolean(customFormsUrl); |
There was a problem hiding this comment.
Suggested change
| const isCustomUrl = Boolean(customFormsUrl); | |
| const hasCustomFormsUrl = Boolean(customFormsUrl); |
denniskigen
reviewed
Sep 12, 2023
| @@ -23,7 +24,7 @@ export function useFormEncounters(cachedOfflineFormsOnly = false, patientUuid: s | |||
| return useSWR([url, cachedOfflineFormsOnly], async () => { | |||
| const res = await openmrsFetch<ListResponse<Form>>(url); | |||
| // show published forms and hide component forms | |||
| const forms = showConfigurableForms | |||
| const forms = isCustomUrl | |||
There was a problem hiding this comment.
Suggested change
| const forms = isCustomUrl | |
| const forms = hasCustomFormsUrl |
denniskigen
previously approved these changes
Sep 12, 2023
donaldkibet
force-pushed
the
enhc/UpdateForms
branch
from
0a7b273
to
040cbab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR removes unused code, following the removal of the
Notes and Formsfrom patient-summary dashboard.From the design
Recommended, completed and All formstabs have been removed in favour of the form-dashboard.I have also maintained the
useCustomFormUrlconfig that we at KenyaHMIS use to display available forms based on some program logic.Screenshots
Related Issue
Other