Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

O3-2551 Make hard-coded maximum duration of dispense in medications a… #1455

Merged
merged 3 commits into from
Nov 7, 2023
Merged

O3-2551 Make hard-coded maximum duration of dispense in medications a… #1455

merged 3 commits into from
Nov 7, 2023

Conversation

CynthiaKamau
Copy link
Collaborator

…pp configurable

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

  • Make hard-coded maximum duration of dispense in medications configurable

Screenshots

https://www.loom.com/share/7867a8ad97774c20b1afdb3c9e14eeab?sid=04050dd5-e2e7-49a0-90ef-f13ee1a84db9

Related Issue

Other

pirupius
pirupius reviewed Nov 6, 2023
View reviewed changes
packages/esm-patient-medications-app/src/config-schema.ts Outdated
@@ -34,4 +39,5 @@ export interface ConfigObject {
};
drugOrderTypeUUID: string;
showPrintButton: boolean;
maxDispenseDurationInDays: boolean;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a mistake. Isn't this supposed to be number

@CynthiaKamau @pirupius
Update packages/esm-patient-medications-app/src/config-schema.ts
e3e66a8 
Co-authored-by: Pius Rubangakene <piruville@gmail.com>
pirupius
pirupius approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@pirupius pirupius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CynthiaKamau

@pirupius pirupius merged commit 2390fa9 into openmrs:main Nov 7, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirupius pirupius pirupius approved these changes

@denniskigen denniskigen Awaiting requested review from denniskigen

@donaldkibet donaldkibet Awaiting requested review from donaldkibet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@CynthiaKamau @pirupius