(O3-2601)[feat] - Hide bottom navigation on tablet, when filling forms #1531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donaldkibet
requested changes
Dec 8, 2023
packages/esm-patient-chart-app/src/patient-chart/action-menu/action-menu.scss
Outdated
Show resolved
Hide resolved
vasharma05
reviewed
Dec 11, 2023
Comment on lines
+101
to
+110
| :global(.omrs-breakpoint-lt-desktop) { | ||
| .hiddenSideRail { | ||
| display: none; | ||
| } | ||
| } | ||
| :global(.omrs-breakpoint-lt-desktop) { | ||
| .showSideRail { | ||
| display: flex; | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| :global(.omrs-breakpoint-lt-desktop) { | |
| .hiddenSideRail { | |
| display: none; | |
| } | |
| } | |
| :global(.omrs-breakpoint-lt-desktop) { | |
| .showSideRail { | |
| display: flex; | |
| } | |
| } | |
| :global(.omrs-breakpoint-lt-desktop) { | |
| .hiddenSideRail { | |
| display: none; | |
| } | |
| .showSideRail { | |
| display: flex; | |
| } | |
| } |
The 2 classes can be clubbed into a single class bracket
There was a problem hiding this comment.
@vasharma05 thanks, though it was merged already
|
Great work @usamaidrsk ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Screenshots
Related Issue
O3-2601
Other