Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) O3-2721: Fix empty state shown when a visit has no encounters #1565

Merged
merged 2 commits into from
Jan 7, 2024

Conversation

psworld
Copy link
Contributor

@psworld psworld commented Jan 7, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR fixes the Ugly empty message when visit has no encounters
When a visit have no encounters then a ugly message is displayed, which is not coherent with O3 style.

Screenshots

Before
image-20240105-193921

After
image

Related Issue

Link to Jira ticket: https://openmrs.atlassian.net/browse/O3-2721

Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @psworld. Thanks.

@denniskigen denniskigen changed the title O3-2721: Fix Ugly empty message when visit has no encounters (fix) O3-2721: Fix empty state shown when a visit has no encounters Jan 7, 2024
@denniskigen denniskigen merged commit ec0a1c7 into openmrs:main Jan 7, 2024
6 checks passed
brandones pushed a commit that referenced this pull request Jan 11, 2024
…1565)

* O3-2721: Fix Ugly empty message when visit has no encounters

* Fix test

---------

Co-authored-by: Ps <ps.world.is.here@gmal.com>
Co-authored-by: Dennis Kigen <kigen.work@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants