(fix) O3-2655: Record Vitals: Error message for invalid values pops up only once

[psworld]

Requirements

• My work includes tests or is validated by existing tests.

Summary

There were two issue:

1. When an invalid value for vitals was entered e.g 400 beats per minute, which is physiologically not possible, the input field did not show the error and the valid range. An argument showErrorMessage was missing from <VitalsAndBiometricsInput /> component.
2. When we save the form with invalid values an inline notification pops up. If after closing the inline notification we again try to save the form with invalid values no notification pops up. This happened because state variable hasInvalidVitals did not change when we again pressed the save form button and hence no re-render was triggered. To fix it, I set the onClose property on the <InlineNotification /> to setHasInvalidVitals(false). This make sure that the re-render occur when I again press the submit button.

Screenshots

Input field validation

Before

No input field error is shown when Blood pressure and Heart rate have invalid values.

After

Inline Notification

Before

Untitled.video.-.Made.with.Clipchamp.mp4

After

Untitled.video.-.Made.with.Clipchamp.2.mp4

Related Issue

Link to JIRA ticket: https://openmrs.atlassian.net/browse/O3-2655

[psworld]

@denniskigen Hello Sir,

Could you please review my PR ?
If any more changes are required please let me know

[denniskigen]

Nice work, @usamaidrsk. Could you add a test?

[usamaidrsk]

Nice work, @usamaidrsk. Could you add a test?

I think that's @psworld .
Thanks

[psworld]

Nice work, @usamaidrsk. Could you add a test?

Thanks.
I will try to add tests as soon as I can.

[psworld]

Hello @denniskigen ,
I have added the tests. Kindly review the changes. Following is description of tests added:

Tests added:

1. Vitals and Biometrics input test :
   It checks for the Invalid Vitals error message. If you add vitals value outside of the reference range, you get an error saying Value must be between min and max. The added test check for presence of this text on screen.

2. Inline Error notification test :
   This test checks for the presence of inline error notification when you try to submit Vitals and Biometrics with invalid values (Values outside of reference range) and test if the inline error notification pop up again after closing the notification and resubmitting the form.

If there are any changes required, please let me know

[denniskigen]

Excellent work! Thanks, @psworld!

[psworld]

Excellent work! Thanks, @psworld!

Thankyou so much. It means a lot to me 🙏