Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) O3-2757: Change all anchor tag cursors from text to pointer type. #1604

Merged
merged 7 commits into from
Jan 23, 2024
Merged

(fix) O3-2757: Change all anchor tag cursors from text to pointer type. #1604

merged 7 commits into from
Jan 23, 2024

Conversation

Pradipram
Copy link
Contributor

@Pradipram Pradipram commented Jan 21, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

The links on the empty state are replaced with Carbon buttons (kind = ghost).

Screenshots

before changes

image

after changes

image

Related Issue

https://openmrs.atlassian.net/jira/software/c/projects/O3/issues/O3-2757?filter=allopenissues

@sherrif10
Copy link
Member

Kindly share a full screen shot of the screen with in all other PRs, they dont look clear.

@Pradipram
Copy link
Contributor Author

@sherrif10

before changes

before.mp4

after changes

after.mp4

Copy link
Member

@sherrif10 sherrif10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM .

@vasharma05
Copy link
Member

vasharma05 commented Jan 22, 2024

The right solution for this is not to add the pointer cursor, but instead to change the link to the Carbon Button (kind = ghost).

The component is present here:

@Pradipram
Copy link
Contributor Author

@vasharma05
I have changed the link to the Carbon Button
Please review this.

@vasharma05
Copy link
Member

vasharma05 commented Jan 23, 2024

Hi @denniskigen @brandones !
Seeking your review on replacing the link to the Button in the empty state.
Thanks!

P.S. 1st widget is the hover state

image

@vasharma05 vasharma05 changed the title Fix O3-2757: Change all anchor tag cursors from text to pointer type. (fix) O3-2757: Change all anchor tag cursors from text to pointer type. Jan 23, 2024
Copy link
Contributor

@brandones brandones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The button implementation appears to conform to the designs. LGTM.

@brandones brandones dismissed vasharma05’s stale review January 23, 2024 17:58

Feedback addressed.

@brandones brandones merged commit 24fa71c into openmrs:main Jan 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants