(feat) O3-2716: Prompt users to close workspaces when navigating from the patient chart #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orkspaces are open
usamaidrsk
commented
Jan 23, 2024
vasharma05
changed the title
brandones
reviewed
Jan 24, 2024
Comment on lines
+80
to
+87
| const navigateToNewUrl = () => { | ||
| function getUrlWithoutPrefix(url: string) { | ||
| return url.split(window['getOpenmrsSpaBase']())?.[1]; | ||
| } | ||
| navigate({ to: `\${openmrsSpaBase}/${getUrlWithoutPrefix(newUrl)}` }); | ||
| }; | ||
|
|
||
| closeAllWorkspaces(navigateToNewUrl); |
There was a problem hiding this comment.
Why is this not adequate?
Suggested change
| const navigateToNewUrl = () => { | |
| function getUrlWithoutPrefix(url: string) { | |
| return url.split(window['getOpenmrsSpaBase']())?.[1]; | |
| } | |
| navigate({ to: `\${openmrsSpaBase}/${getUrlWithoutPrefix(newUrl)}` }); | |
| }; | |
| closeAllWorkspaces(navigateToNewUrl); | |
| closeAllWorkspaces(() => navigate({ to: newUrl });); |
There was a problem hiding this comment.
I referred this in the patient registration from Florian.
The newUrl contains the domain as well, hence it might not be the same handling by single-spa (navigating to /home vs navigating to dev3.openmrs.org/openmrs/spa/home). Navigate function calls the single-spa's navigation.
brandones
reviewed
Jan 24, 2024
|
|
||
| closeAllWorkspaces(navigateToNewUrl); | ||
| } else { | ||
| resetWorkspaceStore(); |
There was a problem hiding this comment.
You should not be using resetWorkspaceStore, per the docstring for that function. What is your intention? Why should the workspace state be cleared?
There was a problem hiding this comment.
Since the user is leaving the patient chart, the workspace can be reset to the initial state.
brandones
reviewed
Jan 24, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Screenshots
add_prompt-on-navigating-from-patient-chart-with-open-workspaces.mp4
Related Issue
O3-2716
Other