Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) O3-2782: Show an inline notification for camera access errors in the add attachment modal #1631

Conversation

usamaidrsk
Copy link
Contributor

@usamaidrsk usamaidrsk commented Feb 1, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR adds an inline notification when user has camera disabled when adding attachments by camera, or any other camera errors

Screenshots

image

Related Issue

O3-2782

Other

@usamaidrsk
Copy link
Contributor Author

@denniskigen please take a look at this provision
Thanks

@denniskigen
Copy link
Member

denniskigen commented Feb 1, 2024

Hey, @usamaidrsk. Thanks for working on this.

Please use the feat conventional commit label in PR titles for pull requests that introduce new features. We don't use an improvement label.

@denniskigen
Copy link
Member

Looks good. I think it's preferable to show a custom error message instead of the default error message from the library. More specifically, I think Please enable camera access in your browser settings and try again is preferable to:

  • CleanShot 2024-02-02 at 2  12 34@2x

@usamaidrsk usamaidrsk changed the title (Improvment) O3-2782: Show an inline notification on camera error when on the attachment modal (feat) O3-2782: Show an inline notification on camera error when on the attachment modal Feb 2, 2024
@denniskigen denniskigen force-pushed the O3-2782-add-inline-notificaiton-on-camera-error branch from 373814e to cf81e04 Compare February 2, 2024 09:00
Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@denniskigen denniskigen changed the title (feat) O3-2782: Show an inline notification on camera error when on the attachment modal (feat) O3-2782: Show an inline notification for camera access errors in the add attachment modal Feb 2, 2024
@denniskigen denniskigen merged commit 9f3f1cd into openmrs:main Feb 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants