-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) Anchor workspace actions to the bottom of the screen in tablet mode #1650
Conversation
Size Change: +228 B (0%) Total Size: 10.7 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @donaldkibet . I approve this so that we can test it more with the pilot sites
height: var(--desktop-workspace-window-height); | ||
// height: var(--desktop-workspace-window-height); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we fix this, since this has been merged?
const isTablet = useLayoutType() === 'tablet'; | ||
useEffect(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would've been nice to keep the newline here...
@@ -77,7 +77,7 @@ const PatientChart: React.FC = () => { | |||
</> | |||
)} | |||
</div> | |||
<ActionMenu open={false} /> | |||
<ActionMenu open={active} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little confused on the logic here? The action menu is open
if the workspace is active? It feels like we might've needed a different prop for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ibacher It seems I may have misinterpreted the original idea. The intention is to conceal the action menu on tablet devices when a workspace form is open, allowing for increased working space on smaller tablets. I will do a follow on PR to address it.
The CSS change was actually meant to be done in the workspace-window.component rather than individual workspaces |
Requirements
Summary
This fixes an issue with tablet not showing the action buttons on tablet devices. It anchors the action buttons at the bottom.
Screenshots
Related Issue
Other