Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) O3-2877: Make the drug search debounce delay value configurable #1680

Merged
merged 8 commits into from
Feb 20, 2024
Merged

(fix) O3-2877: Make the drug search debounce delay value configurable #1680

merged 8 commits into from
Feb 20, 2024

Conversation

jwnasambu
Copy link
Contributor

@jwnasambu jwnasambu commented Feb 19, 2024 •
edited by denniskigen

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

I customized the debounce time by passing the debounceTime prop when using the DrugSearch component by setting debounceTime={300 milliseconds}

Screenshots

Related Issue

https://openmrs.atlassian.net/browse/O3-2877

Other

@denniskigen denniskigen changed the title (fix)O3-2877:Increase debounce time while searching for drug on medication order form. (fix)O3-2877: Make the drug search debounce delay value configurable Feb 20, 2024
@denniskigen denniskigen changed the title (fix)O3-2877: Make the drug search debounce delay value configurable (fix) O3-2877: Make the drug search debounce delay value configurable Feb 20, 2024
@denniskigen
Copy link
Member

denniskigen commented Feb 20, 2024 •
edited

This LGTM, @jwnasambu. Thanks. I'll let @donaldkibet look through it to assert it matches his requirements from the ticket before merging.

@jwnasambu
Copy link
Contributor Author

@denniskigen Thanks for the guidance and mentorship.I have learnt a new skill from you.

@ibacher ibacher merged commit d105a5a into openmrs:main Feb 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denniskigen denniskigen denniskigen approved these changes

@ibacher ibacher ibacher approved these changes

@donaldkibet donaldkibet Awaiting requested review from donaldkibet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jwnasambu @denniskigen @ibacher