(feat) Conditionally make the order reason field of the lab order form required when configured #1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makombe
force-pushed
the
order-reason
branch
from
e86aed2
to
55e41e2
Compare
donaldkibet
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
LGTM Thanks @makombe, consider incorporating a unit test to prevent regressions
packages/esm-patient-labs-app/src/lab-orders/add-lab-order/lab-order-form.component.tsx
Show resolved
Hide resolved
denniskigen
changed the title
|
Thanks, @makombe! |
usamaidrsk
pushed a commit
to usamaidrsk/openmrs-esm-patient-chart
that referenced
this pull request
Mar 11, 2024
…m required when configured (openmrs#1698) Conditionally make order reason required when configured Co-authored-by: Dennis Kigen <kigen.work@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR introduces the ability specify if order reason is required for given test(s) which have the order reason configured.
Screenshots
Related Issue
Other