(fix) O3-2852: Fix the viewport size of the Start Visit form on tablet #1765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@denniskigen I Fixed this error. Can you review it.. |
|
@Madhu-mac Kindly Add the ticket link associated with the issue. |
denniskigen
reviewed
May 8, 2024
| @@ -46,7 +45,7 @@ | |||
| display: flex; | |||
| flex-direction: column; | |||
| justify-content: space-between; | |||
| height: calc(100vh - 6rem); | |||
There was a problem hiding this comment.
@Madhu-mac changing the height to 100vh breaks the UI on the desktop viewport. The correct values are:
var(--desktop-workspace-window-height)for desktopvar(--tablet-workspace-window-height)for tablet
As defined here
This is what the corresponding UI looks like following those changes:
Desktop
Tablet
denniskigen
changed the title
denniskigen
approved these changes
May 8, 2024
alaboso
added a commit
that referenced
this pull request
May 27, 2024
* (feat) O3-3156: Submitting the start visit form should mutate appointments (#1825) * (fix) O3-2852: Fix the viewport size of the Start Visit form on tablet (#1765) * Overlapping issue fixed in visit-form * Make viewport height responsive - different values for desktop and tablet --------- Co-authored-by: Mutesasira Moses <mozzymutesa@gmail.com> Co-authored-by: Dennis Kigen <kigen.work@gmail.com> * (refactor) O3-2626: Reuse useAllowedFileExtensions hook from Common Lib (#1827) (refactor) Reuse allowedFileExtensions hook from Common Lib * (feat) O3-3158: Conditionally render Patient Header in the Start Visit form (#1823) * (feat) O3-3158: Visit Form should support (optionally) rendering Patient Header * (feat) O3-3158: Visit Form should support (optionally) rendering Patient Header --------- Co-authored-by: Dennis Kigen <kigen.work@gmail.com> * (chore) Bump form-engine lib (#1828) Bump form-engine lib * (chore) Bump form-engine lib (#1829) Bump form-engine lib * (fix) Widen range to detect "current" data entry * (fix) O3-3158: Follow-up commit fixing patientUuid sometimes undefined (#1831) * (feat) O3 3128: Add extension slots to lab and drug order forms (#1818) * (feat) Add slots to labs and drug form * O3-3128 (feat) Enhance lab, orders and dispensing form with addition slot * Fixup --------- Co-authored-by: Dennis Kigen <kigen.work@gmail.com> * (chore) Bump RFE version (#1833) * Bump RFE version * Update to next * (fix) O3-3196: Fix diagnoses tags display on tablet (#1834) * (fix) O3-3195: Fix rendering logic for the weight tile (#1835) * (fix) return encounter type uuid from encounter type object (#1836) return uuid from encounter type object * (chore) Bump React form engine and yarn (#1837) * (chore) Release v8.0.0 (#1839) * (feat) O3-2430: User should be able to look up frequency in dropdown by abbreviation (#1767) Co-authored-by: Dennis Kigen <kigen.work@gmail.com> Co-authored-by: Ian <52504170+ibacher@users.noreply.github.com> * (chore) Release v8.0.1 (#1841) Co-authored-by: Dennis Kigen <kigen.work@gmail.com> * (chore) Bump react and related types (#1842) * (chore) Bump react and related types * Fixup * Bump test deps to remove warnings * (fix) O3-3158: Restore abortControllers * Revert "(fix) O3-3158: Restore abortControllers" This reverts commit 0895e27. * (fix) O3-3158: Restore abortControllers (#1843) * (chore) Bump react form engine * (fix) O3-3175: Remove Breadcrumbs menu from Patient Chart (#1832) * (fix)- O3-3175 Remove Breadcrumbs * Remove translation strings * Remove more occurrences of breadcrumbs --------- Co-authored-by: Dennis Kigen <kigen.work@gmail.com> * (feat) Update custom representation to match required properties for encounter observation (#1845) * Make attachment upload modal span full-width * (chore) Bump react form engine (#1846) * (feat) O3-2626: Add the ability to upload multiple images in the Visit Note form (#1826) Co-authored-by: Dennis Kigen <kigen.work@gmail.com> * (fix) O3-3284: Display correctly formatted patient name throughout patient chart apps (#1849) * Display formatted patient name in visit-header and patient-details-tile components * Display formatted patient name in patient-banner component. * Display formatted patient name in esm-patient-labs-app * Display formatted patient name in esm-patient-medications-app * Display formatted patient name in esm-patient-orders-app * Display formatted patient name in esm-patient-vitals-app * Bump core tooling * (feat) O3-3165: Add confirmation modal when deleting repeat question (#1840) * (feat): Add confirmation modal when deleting repeat question * (refactor): register modal as extension * (refactor): change modal registration name * Bump form engine and core tooling --------- Co-authored-by: Dennis Kigen <kigen.work@gmail.com> --------- Co-authored-by: Mark Goodrich <mgoodrich@pih.org> Co-authored-by: Madhu Lokesh <madhumj623@gmail.com> Co-authored-by: Mutesasira Moses <mozzymutesa@gmail.com> Co-authored-by: Dennis Kigen <kigen.work@gmail.com> Co-authored-by: Samuel Male <samuelsmalek@gmail.com> Co-authored-by: Ian <ian.c.bacher@gmail.com> Co-authored-by: Ian <52504170+ibacher@users.noreply.github.com> Co-authored-by: Donald Kibet <chelashawdonald@yahoo.com> Co-authored-by: Jamie Arodi <51090527+arodidev@users.noreply.github.com> Co-authored-by: Thembo Jonathan <jonathanthembo123@gmail.com> Co-authored-by: Piyush Mishra <91911367+piyushmishra1416@users.noreply.github.com> Co-authored-by: Vineet Sharma <sharmava05@gmail.com> Co-authored-by: Bhargav kodali <115476530+kb019@users.noreply.github.com> Co-authored-by: jwnasambu <33891016+jwnasambu@users.noreply.github.com> Co-authored-by: Gavin Falconer <gfalconer@xprl.co.uk> Co-authored-by: Nethmi Rodrigo <34070216+NethmiRodrigo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Fixes the Start Visit form UI on the tablet viewport so that the form covers the entire vertical height of the viewport.
Screenshots
Before
After
Related issue
https://openmrs.atlassian.net/issues/O3-2852