Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) Limit workflow task parallelization #688

Merged
merged 3 commits into from May 9, 2022

Conversation

denniskigen
Copy link
Member

@denniskigen denniskigen commented May 5, 2022

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • My work includes tests or is validated by existing tests.

Summary

This PR limits the number of tasks that run in parallel in our CI workflow. This is to reduce the likelihood of the CI workflow execution running out of memory.

It does so by factoring out the lint and typescript jobs into their own pipeline, separate from the build pipeline.

This PR limits the number of tasks that run in parallel in our CI workflow. This is so as to reduce the likelihood of the CI workflow execution running out of memory. It does so by separating the `lint` and `typescript` jobs into their own pipeline that is separate from the `build` job.
@brandones
Copy link
Contributor

Why not use the --concurrency flag?

@denniskigen
Copy link
Member Author

denniskigen commented May 9, 2022

Why not use the --concurrency flag?

Sure. I still reckon it's sensible to separate the formatting and type checking jobs from the build step. It'd be easier to determine what resources to allocate to the two jobs when separate. The build job concurrency likely needs tweaking downwards to mitigate resource use, whereas the formatting jobs could go full turbo.

@brandones brandones merged commit 3f51832 into master May 9, 2022
@brandones brandones deleted the chore-limit-concurrent-jobs branch May 9, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants