Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "(feat) Add a build script for patient-common-lib (#717)" #722

Merged
merged 1 commit into from Jun 17, 2022

Conversation

ibacher
Copy link
Member

@ibacher ibacher commented Jun 17, 2022

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • My work includes tests or is validated by existing tests.

Summary

With apologies to @ZacButko, this reverts commit 419aec9 which may or may not be causing the problem on dev3.

Screenshots

Related Issue

Other

Copy link
Member

@manuelroemer manuelroemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this is a good idea to at least try out right now since the patient chart is basically unusable at the moment (in the online version). If that doesn't fix the issue we can revert the revert afterwards.

If it does help, we need to figure out how to build the common lib as a separate file without causing the chart to crash. I'm honestly not quite sure at the moment how to do that/why it's a problem in the first place.

Thanks for creating the PR @ibacher!

@ibacher ibacher merged commit 0dbfb7c into master Jun 17, 2022
@ibacher ibacher deleted the revert-build-script branch June 17, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants