Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Useful tweaks following the 4.0 upgrade #768

Merged
merged 2 commits into from Aug 17, 2022
Merged

Conversation

denniskigen
Copy link
Member

@denniskigen denniskigen commented Aug 11, 2022

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • My work includes tests or is validated by existing tests.

Summary

This PR makes some useful tweaks following the 4.0 upgrade. These include:

  • Removing an errant semi-colon from the form entry wrapper component.
  • Fix mismatched style declaration in the Biometrics chart component.
  • Tweak the modal copy in the Cancel Visit dialog component.
  • Upgrade the @carbon/charts-react and d3 version in the Test Results app.
  • Alter the description property of the Test Results app package.json file.

Screenshots

Things working

Screenshot 2022-08-12 at 02 08 08

Screenshot 2022-08-12 at 02 08 26

@ibacher
Copy link
Member

ibacher commented Aug 15, 2022

@denniskigen Could you resolve the conflict?

These include:

- Removing an errant semi-colon from the form entry wrapper component.
- Fix mismatched style declaration in the Biometrics chart component.
- Tweak the modal copy in the Cancel Visit dialog component.
- Upgrade the `@carbon/charts-react` and `d3` version in the Test Results app.
- Alter the description property of the Test Results app package.json file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants