Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) upgrade to Yarn v3 #769

Merged
merged 2 commits into from Aug 15, 2022
Merged

(chore) upgrade to Yarn v3 #769

merged 2 commits into from Aug 15, 2022

Conversation

ibacher
Copy link
Member

@ibacher ibacher commented Aug 15, 2022

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide.
  • My work includes tests or is validated by existing tests.

Summary

Pretty simple: gets us to Yarn v3.

Screenshots

Related Issue

Other

@@ -72,7 +72,7 @@
"webpack-cli": "^4.7.0"
},
"resolutions": {
"**/@types/react": "^18.0.14",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we no longer need to resolve React? This has always been painful in the past...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, we might need to re-add it back depending on what happens with React 19, but for now I'd prefer to remove it 😁. (Yarn 3's syntax for this is also somewhat different so the "**/@types/react" is actually no longer valid).

@ibacher ibacher merged commit 60d28ea into main Aug 15, 2022
@ibacher ibacher deleted the yarn-v3 branch August 15, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants