Enhanced Monthly Calendar UI for Appointment Scheduler

[gabriel090]

Requirements

• This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
• My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
• My work includes tests or is validated by existing tests.

Summary

This enhances the UI of the monthly calendar view in the appointment scheduler. The updated design provides a visually appealing layout compared to the previous version, improving the overall user experience. The modifications include refining the layout, enhancing visual elements, and ensuring a more intuitive navigation experience for users interacting with the calendar.

Screenshots

This is the appointment calendar view scheduler before the upgrade

The new Calendar view after modification

Related Issue

Other

[mogoodrich]

Generally looks good to me, thanks @gabriel090 !

Can we use translation strings for the days of the week (see my comment).

Also, per my other comment, I might not be following the code properly, but I don't think we'd want clicking on a date within the month few to change the whiole date "context", but just to change the value of the appointment date file on the form.

But generally, this looks much better than before, thanks for working on this!

[ojwanganto]

@mogoodrich @gabriel090 - is there a reason we need both the weekly and monthly views? Could we retain just the monthly one?

[mogoodrich]

@ojwanganto I would totally be in favor of the removing the weekly view and just keeping the monthly view, it seemed duplicative to me as well.

[ojwanganto]

@gabriel090 please consider removing the weekly distribution. It is already part of the monthly view which eventually reduces the number of clicks. Thanks @mogoodrich

[gabriel090]

@gabriel090 please consider removing the weekly distribution. It is already part of the monthly view which eventually reduces the number of clicks. Thanks @mogoodrich

Fixed.

[mogoodrich]

Thanks @ojwanganto ! yes, @gabriel090 do you want to remove the weekly view as part of this PR, or we can ticket it as a separate ticket/PR if that is easier, I realize the weekly view predates your changes. Thanks!

[mogoodrich]

Oh @gabriel090 apologies, I think you have already updated the PR to remove the weekly view... is this good to go from your perspective, I'm happy to merge.

[mogoodrich]

I am going to go ahead and merge this in so we can test (the E2E error appears to be unrelated). Thanks @gabriel090

[mogoodrich]

So @gabriel090 I'm seeing some issues with this, when used from the "Appointments" section, first when you select a date, the appointment date picker gets set to the date before the selected date (I'm wondering if this is a timezone issue, I'm in Eastern time). And then when I save the appointment, it seems to get created on the current day, not the date selected.

Screencast.from.03-21-2024.03.47.37.PM.webm

[gabriel090]

So @gabriel090 I'm seeing some issues with this, when used from the "Appointments" section, first when you select a date, the appointment date picker gets set to the date before the selected date (I'm wondering if this is a timezone issue, I'm in Eastern time). And then when I save the appointment, it seems to get created on the current day, not the date selected.

Screencast.from.03-21-2024.03.47.37.PM.webm

@mogoodrich Thank you for the feedback. This is in working progress, I will update you once it is done. Thank you

[mogoodrich]

Thanks @gabriel090 , I ticked this here: https://openmrs.atlassian.net/browse/O3-2998
And it actually looks like someone already attempted a fix, but I will defer to you for the initial review:
https://github.com/openmrs/openmrs-esm-patient-management/pull/1072/files

[gabriel090]

Thanks @gabriel090 , I ticked this here: https://openmrs.atlassian.net/browse/O3-2998 And it actually looks like someone already attempted a fix, but I will defer to you for the initial review: https://github.com/openmrs/openmrs-esm-patient-management/pull/1072/files

Thanks, @mogoodrich, for the feedback, and I appreciate that someone is attempting to fix the issue. However, in the original issue, when creating an appointment and picking a date from the calendar scheduler, the appointment is saved for the current day, which still persists. I am currently working on it. Thanks.