Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(test)O3-2215: Add tests for field.component #741

Merged
merged 3 commits into from Jun 30, 2023

Conversation

ayush-AI
Copy link
Contributor

Requirements

Summary

In this PR I have added the Tests for field.component.tsx of esm-patient-registration-app.

Screenshots

Screenshot 2023-06-24 at 10 30 08 PM

Related Issue

https://issues.openmrs.org/browse/O3-2215

Other

None.

@ayush-AI
Copy link
Contributor Author

@ayush-AI ayush-AI marked this pull request as draft June 24, 2023 17:03
@ayush-AI ayush-AI changed the title (test)O3-2215: Adds Tests for field.component (test)O3-2215: Add tests for field.component Jun 24, 2023
deathDate: '',
deathCause: '',
relationships: [],
identifiers: { mockedIdentifierTypes },
Copy link
Contributor Author

@ayush-AI ayush-AI Jun 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opening this draft PR to get some help on one of the failing test i.e. should render Identifiers component when name prop is "id" . The test if failing because of the incorrect mock value of identifiers. What value should I pass here to get this test Pass ? Please suggest cc / @jayasanka-sack @Piumal1999 @anjula-sack @denniskigen

@ayush-AI ayush-AI marked this pull request as ready for review June 29, 2023 16:41
@ayush-AI
Copy link
Contributor Author

The failing test is passing now and please review. cc/ @jayasanka-sack @Piumal1999 @anjula-sack

Copy link
Collaborator

@anjula-sack anjula-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @ayush-AI

@anjula-sack anjula-sack merged commit a0a668d into openmrs:main Jun 30, 2023
7 checks passed
@ayush-AI ayush-AI deleted the field branch August 1, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants