(test) O3-2225 O3-2226: Add tests for cancel-patient-edit.component and delete-identifier-confirmation-modal #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piumal1999
requested changes
Jul 3, 2023
Comment on lines
14
to
16
| const { getByRole } = render(<CancelPatientEdit close={mockClose} onConfirm={mockOnConfirm} />); | ||
|
|
||
| const cancelButton = getByRole('button', { name: /Cancel/i }); |
There was a problem hiding this comment.
Can we do it like this?
Suggested change
| const { getByRole } = render(<CancelPatientEdit close={mockClose} onConfirm={mockOnConfirm} />); | |
| const cancelButton = getByRole('button', { name: /Cancel/i }); | |
| render(<CancelPatientEdit close={mockClose} onConfirm={mockOnConfirm} />); | |
| const cancelButton = screen.getByRole('button', { name: /Cancel/i }); |
packages/esm-patient-registration-app/src/widgets/cancel-patient-edit.test.tsx
Show resolved
Hide resolved
Piumal1999
approved these changes
Jul 12, 2023
ayush-AI
added a commit
to ayush-AI/openmrs-esm-patient-management
that referenced
this pull request
Jul 13, 2023
…ete-identifier-confirmation-modal (openmrs#750)
anjula-sack
added a commit
that referenced
this pull request
Jul 13, 2023
* added test for utils.ts * resolved review commits * (feat) Remove filtering todays queue entries on frontend (#752) * (refactor): Display all active visits by removing filter for showing only today's active visits (#755) * (refactor): changed activeVisits.idNumber assignment for improved code robustness (#756) * (feat) O3-2100: Unknown patient name and estimated DOB config (#697) Co-authored-by: Vineet Sharma <sharmava05@gmail.com> * (test) O3-2225/6: Add tests for cancel-patient-edit.component and delete-identifier-confirmation-modal (#750) * removed the extra types --------- Co-authored-by: Anjula Shanaka <anjulashanaka@gmail.com> Co-authored-by: Dennis Kigen <kigen.work@gmail.com> Co-authored-by: CynthiaKamau <cynthiakamau54@gmail.com> Co-authored-by: Donald Kibet <chelashawdonald@yahoo.com> Co-authored-by: Jexsie <jessiessebuliba@gmail.com> Co-authored-by: Vineet Sharma <sharmava05@gmail.com>
ayush-AI
added a commit
to ayush-AI/openmrs-esm-patient-management
that referenced
this pull request
Jul 13, 2023
…ete-identifier-confirmation-modal (openmrs#750)
ayush-AI
added a commit
to ayush-AI/openmrs-esm-patient-management
that referenced
this pull request
Jul 13, 2023
* added test for utils.ts * resolved review commits * (feat) Remove filtering todays queue entries on frontend (openmrs#752) * (refactor): Display all active visits by removing filter for showing only today's active visits (openmrs#755) * (refactor): changed activeVisits.idNumber assignment for improved code robustness (openmrs#756) * (feat) O3-2100: Unknown patient name and estimated DOB config (openmrs#697) Co-authored-by: Vineet Sharma <sharmava05@gmail.com> * (test) O3-2225/6: Add tests for cancel-patient-edit.component and delete-identifier-confirmation-modal (openmrs#750) * removed the extra types --------- Co-authored-by: Anjula Shanaka <anjulashanaka@gmail.com> Co-authored-by: Dennis Kigen <kigen.work@gmail.com> Co-authored-by: CynthiaKamau <cynthiakamau54@gmail.com> Co-authored-by: Donald Kibet <chelashawdonald@yahoo.com> Co-authored-by: Jexsie <jessiessebuliba@gmail.com> Co-authored-by: Vineet Sharma <sharmava05@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
In this PR I have added the tests for delete-identifier-confirmation-modal and cancel-patient-edit.component.
Screenshots
None.
Related Issue
https://issues.openmrs.org/browse/O3-2225
https://issues.openmrs.org/browse/O3-2226
Other
None.