(fix) O3-2284: Fix failing patient registration test #763
Conversation
example.env
Outdated
| @@ -1,5 +1,5 @@ | |||
| # This is an example environment file for configuring dynamic values. | |||
| E2E_BASE_URL=http://localhost:8080/openmrs | |||
| E2E_BASE_URL=https://dev3.openmrs.org/openmrs | |||
There was a problem hiding this comment.
I'd prefer if the example setup didn't point at dev3. We need to limit the usage of dev3 for automated testing.
There was a problem hiding this comment.
Yeah, I just wanted to verify that it works with dev3. The patient registration didn't pass when running locally. It fails to load the patient-chart view after creating a patient. I'm still looking into fixing that bug.
I'm going to revert the line after it is resolved.
| @@ -77,7 +77,7 @@ export const generateRandomPatient = async (api: APIRequestContext): Promise<Pat | |||
| ], | |||
| attributes: [], | |||
| birthdate: '2020-2-1', | |||
| birthdateEstimated: true, | |||
| birthdateEstimated: false, | |||
There was a problem hiding this comment.
Yeah. If we use birthdayEstimated as true, it will take the patient as a "patient with an unknown birthdate". So when we go to the edit patient page, it will automatically use the "Birthdate unknown" option.
(That change was added with 7dbf922. And the tests were failing after that)
There was a problem hiding this comment.
PS While it may not matter much, it's less ambiguous (and more likely to work everywhere) if we stick to ISO 8601 for dates, i.e., 2020-02-01.
There was a problem hiding this comment.
Yeah, that's right. I changed the date format.
Co-authored-by: Ian <52504170+ibacher@users.noreply.github.com>
* Dynamic frontend Docker image for e2e test * Change directory * Fix tests * Update e2e/support/github/run-e2e-docker-env.sh Co-authored-by: Ian <52504170+ibacher@users.noreply.github.com> * Update e2e/support/github/Dockerfile Co-authored-by: Ian <52504170+ibacher@users.noreply.github.com> * Fix the port numbers * Remove unwanted MFs * Remove unwanted MFs * Remove unwanted MFs * Remove unwanted MFs * Remove unwanted MFs * Test only with login and home apps * Test with navigation, chart and home apps * (Breaking) Revert the changes related to #763 --------- Co-authored-by: Ian <52504170+ibacher@users.noreply.github.com>
There was a problem hiding this comment.
@Piumal1999 I merged latest changes to your PR and reran tests. All the test cases are passing now.
Requirements
Summary
Fixed the failing patient registration e2e test:
Screenshots
None.
Related Issue
https://issues.openmrs.org/browse/O3-2284
Other
None.