Show 'slots' syntax #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated extensions declaration to show 'slots' syntax. More clear how to use slot vs slots. Let me know if you guys think this is silly, but this took me a while to track down why it wasn't working 😅
brandones
reviewed
Feb 17, 2022
Co-authored-by: Brandon Istenes <bistenes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated extensions declaration to show 'slots' syntax. More clear how to use slot vs slots.
Let me know if you guys think this is silly, but this took me a while to track down why it wasn't working 😅
I assumed from http://o3-dev.docs.openmrs.org/#/main/extensions page hint "The extension names the slot in its definition, under
slot[s]" that the syntax would beslot: "Boxes"singular andslot: ["Boxes"]plural, notslots: ["Boxes"]. In retrospect wording on that page makes sense, but it would be good to show example in the example code