Fixing XSS bug in manageAppointments.gsp #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isears
requested changes
Jul 26, 2021
| @@ -338,7 +338,7 @@ | |||
| </repository> | |||
| <repository> | |||
| <id>rubygems-releases</id> | |||
| <url>http://rubygems-proxy.torquebox.org/releases</url> | |||
| <url>https://rubygems-proxy.torquebox.org/releases/url</url> | |||
There was a problem hiding this comment.
I think this change was part of your other pull request. Try git pull --rebase master on your PR branch and then force push with git push -f so that we can keep this PR focused on the XSS fix only.
| @@ -7,7 +7,7 @@ | |||
| <script type="text/javascript"> | |||
| <% if (breadcrumbOverride) { %> | |||
| var breadcrumbs = _.flatten([ | |||
| ${ breadcrumbOverride }, | |||
| ${ ui.encodeJavaScript(breadcrumbOverride) }, | |||
There was a problem hiding this comment.
When I test this locally, the manageAppointment page loses most of the functionality it had before the patch. Are you getting similar behavior?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to find the XSS bug:
My fix:
I located the line to fix in manageAppointments.gsp using inspect element, then used the ui.encodeJavaScript() function on the correct breadcrumbOverride parameter which escaped special characters to stop the XSS attack.
@isears