Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RA-1625: Unable to display inactive conditions #171

Closed
wants to merge 1 commit into from
Closed

RA-1625: Unable to display inactive conditions #171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions web-2.2/src/main/java/org/openmrs/module/emrapi/web/controller/ConditionController.java
View file
Open in desktop
Expand Up @@ -374,9 +374,9 @@ private org.openmrs.module.emrapi.conditionslist.Condition convertCoreConditionT
@RequestMapping(method = RequestMethod.GET, value = "/conditionhistory")
@ResponseBody
public List<org.openmrs.module.emrapi.conditionslist.contract.ConditionHistory> getConditionHistory(@RequestParam("patientUuid") String patientUuid) {
List<org.openmrs.Condition> activeConditions = conditionService.getActiveConditions(patientService.getPatientByUuid(patientUuid));
List<org.openmrs.Condition> conditions = conditionService.getAllConditions(patientService.getPatientByUuid(patientUuid));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haripriya999 , Obviously this method doesnt exist any where in the core, it still lives in your PR , theres no way you can call it from here . Until your Pr is merged and at the same time you depend on the latest changes in the master , or probably its back ported to the core version that core apps depends on

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mozzy11 Thank you for your insight on this. Is it that every time the module build takes places, it uses internet to get the latest changes?


return conditionHistoryMapper.map(convertHistory(activeConditions));
return conditionHistoryMapper.map(convertHistory(conditions));
}

@RequestMapping(method = RequestMethod.GET, value = "/condition")
Expand Down